From: Geliang Tang <tanggeliang@kylinos.cn>

v2:
 - address Matt's comments in v1.
 - all for -next, not -net.
 - add two more patches.

Part 1 of "add helpers and vars in mptcp_lib.sh", some fixes.

Geliang Tang (7):
  selftests: mptcp: netlink: drop duplicate var ret
  selftests: mptcp: simult flows: define missing vars
  selftests: mptcp: join: change capture/checksum as bool
  selftests: mptcp: diag: change timeout_poll to 30
  selftests: mptcp: drop iptables/ip6tables vars
  selftests: mptcp: add ss mptcp support checks
  selftests: mptcp: add mptcp_lib_check_tools helper

 tools/testing/selftests/net/mptcp/diag.sh     | 15 +----
 .../selftests/net/mptcp/mptcp_connect.sh      |  9 +--
 .../testing/selftests/net/mptcp/mptcp_join.sh | 55 ++++++-------------
 .../testing/selftests/net/mptcp/mptcp_lib.sh  | 29 ++++++++++
 .../selftests/net/mptcp/mptcp_sockopt.sh      | 25 ++-------
 .../testing/selftests/net/mptcp/pm_netlink.sh |  9 +--
 .../selftests/net/mptcp/simult_flows.sh       | 14 ++---
 .../selftests/net/mptcp/userspace_pm.sh       |  8 +--
 8 files changed, 62 insertions(+), 102 deletions(-)

-- 
2.40.1

Hi Geliang,

On 16/02/2024 10:50, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> v2:
>  - address Matt's comments in v1.
>  - all for -next, not -net.
>  - add two more patches.

Thank you for the v2.

Patches 1-4 are OK for me. I can apply them already.

I don't think we need 5/7, and I have some comments for the two last ones.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

Hi Geliang,

On 16/02/2024 14:43, Matthieu Baerts wrote:
> Hi Geliang,
> 
> On 16/02/2024 10:50, Geliang Tang wrote:
>> From: Geliang Tang <tanggeliang@kylinos.cn>
>>
>> v2:
>>  - address Matt's comments in v1.
>>  - all for -next, not -net.
>>  - add two more patches.
> 
> Thank you for the v2.
> 
> Patches 1-4 are OK for me. I can apply them already.

Just did. I slightly modified some commit messages, I hope that's OK.

Now in our tree, feat. for next.

New patches for t/upstream:
- ce771d245e7a: selftests: mptcp: netlink: drop duplicate var ret
- 980763004b18: selftests: mptcp: simult flows: define missing vars
- 99e3296b940f: selftests: mptcp: join: change capture/checksum as bool
- 247b270f3921: selftests: mptcp: diag: change timeout_poll to 30
- Results: 65bda47e218b..b95a6fc53895 (export)

Tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20240216T135434

Cheers,
Matt--
Sponsored by the NGI0 Core fund.