[v1] add helpers and vars in mptcp_lib.sh, part 1

[PATCH mptcp-net 0/5] add helpers and vars in mptcp_lib.sh, part 1

Geliang Tang posted 5 patches 2 months, 2 weeks ago

Diff against v2 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1707797566.git.tanggeliang@kylinos.cn

There is a newer version of this series

tools/testing/selftests/net/mptcp/diag.sh     |  2 +-
.../selftests/net/mptcp/mptcp_connect.sh      |  6 ++++
.../testing/selftests/net/mptcp/mptcp_join.sh | 28 +++++++++++--------
.../selftests/net/mptcp/mptcp_sockopt.sh      |  6 ++++
.../testing/selftests/net/mptcp/pm_netlink.sh |  1 -
.../selftests/net/mptcp/simult_flows.sh       |  6 ++++
6 files changed, 36 insertions(+), 13 deletions(-)

Expand all Fold all

[PATCH mptcp-net 0/5] add helpers and vars in mptcp_lib.sh, part 1

Posted by Geliang Tang 2 months, 2 weeks ago

From: Geliang Tang <tanggeliang@kylinos.cn>

Part 1 of "add helpers and vars in mptcp_lib.sh", some fixes.

Geliang Tang (5):
  selftests: mptcp: netlink: drop duplicate var ret
  selftests: mptcp: simult flows: define missing vars
  selftests: mptcp: add ss mptcp support checks
  selftests: mptcp: join: change capture/checksum as bool
  selftests: mptcp: diag: change timeout_poll to 30

 tools/testing/selftests/net/mptcp/diag.sh     |  2 +-
 .../selftests/net/mptcp/mptcp_connect.sh      |  6 ++++
 .../testing/selftests/net/mptcp/mptcp_join.sh | 28 +++++++++++--------
 .../selftests/net/mptcp/mptcp_sockopt.sh      |  6 ++++
 .../testing/selftests/net/mptcp/pm_netlink.sh |  1 -
 .../selftests/net/mptcp/simult_flows.sh       |  6 ++++
 6 files changed, 36 insertions(+), 13 deletions(-)

-- 
2.40.1

Re: [PATCH mptcp-net 0/5] add helpers and vars in mptcp_lib.sh, part 1

Posted by Matthieu Baerts 2 months, 2 weeks ago

Hi Geliang,

On 13/02/2024 05:14, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> Part 1 of "add helpers and vars in mptcp_lib.sh", some fixes.
> 
> Geliang Tang (5):
>   selftests: mptcp: netlink: drop duplicate var ret
>   selftests: mptcp: simult flows: define missing vars
>   selftests: mptcp: add ss mptcp support checks
>   selftests: mptcp: join: change capture/checksum as bool
>   selftests: mptcp: diag: change timeout_poll to 30

Thank you for the new series!

I think only patches 1/5 and 3/5 are for -net. I also have some comments
in some of them. Please check the individual patches.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.