On Thu, 1 Feb 2024, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> v11:
> - update patch 5 as Mat suggested.
> - depends on "fixes for userspace PM" series.
>
Hi Geliang -
Thanks for the changes, code looks good to me!
I tried applying v11 after 'fixes for "map v4 address to v6"' but it still
doesn't apply cleanly, can you rebase this series and repost?
- Mat
> v10:
> - fix a checkpatch.sh warning reported by CI.
> - fix build warnings reported by kernel test robot <lkp@intel.com>.
>
> v9:
> - add missing "sock_put(sk)" in patch 7, 17 and 21 to fix the "kmemleak"
> errors reported by CI.
> - rename the helper to mptcp_pm_has_addr_attr_id.
> - use my new mail address.
>
> v8:
> - Address Mat's comments in v7
>
> v7:
> - fix checkpatch.sh warning reported by CI.
> - fix build errors reported by CI.
>
> v6:
> - patches 1-5, fixes for -net
> - patches 6, 15, selftests for "fixes for -net".
> - patches 7-14, 16-21, update "dump for userspace pm v5"
> - patches 22, 23, cleanups for set_flags
> - patch 24, flush selftest.
>
> v5:
> - patch 2, save bitmap instead of id.
> - patch 3, drop token in reply.
> - update patch 4 and patch 12, add mptcp_pm_dump_addr and
> mptcp_pm_get_addr wrappers in pm.c
>
> v4:
> - update patch 2, patch 3 and patch 12.
> - fix the warnings reported by CI in v3:
>
> Unable to validate one commit: 7633a101a mptcp: get addr in userspace pm list
> Unable to compile mptcp source code with make W=1 net/mptcp/pm_netlink.o
> Unable to compile mptcp source code with make C=1 net/mptcp/pm_netlink.o: net/mptcp/pm_netlink.c:1656:5: warning: symbol 'mptcp_pm_nl_get_addr' was not declared. Should it be static?
>
> v3:
> - fix the errors reported by CI in v2:
>
> [10:55:51.288] [ 897.523894][ T5664] BUG: sleeping function called from invalid context at include/linux/sched/mm.h:306
> [10:55:51.288] [ 897.532157][ T5664] in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 5664, name: pm_nl_ctl
> [10:55:51.289] [ 897.539503][ T5664] preempt_count: 201, expected: 0
>
> - drop mptcp_pm_nl_put_entry_msg and mptcp_pm_nl_put_entry_info
> helpers.
>
> v2:
> Address Mat's comments in v1:
> - patch 2: pass token to dump_addr too.
> - patch 2: add back id in mptcp_userspace_pm_dump_addr().
> - patch 5: update mptcp.yaml
>
> v1:
> Address Mat's comments in "userspace pm enhancements" v14.
>
> Geliang Tang (15):
> mptcp: export mptcp_genl_family & mptcp_nl_fill_addr
> mptcp: implement mptcp_userspace_pm_dump_addr
> mptcp: add token for get-addr in yaml
> mptcp: dump addrs in userspace pm list
> mptcp: check userspace pm flags
> selftests: mptcp: add userspace pm subflow flag
> selftests: mptcp: add token for dump_addr
> selftests: mptcp: add check_output helper
> selftests: mptcp: dump after creating id 0 subflow
> selftests: mptcp: dump userspace addrs list
> mptcp: add userspace_pm_lookup_addr_by_id helper
> mptcp: implement mptcp_userspace_pm_get_addr
> mptcp: get addr in userspace pm list
> selftests: mptcp: add token for get_addr
> selftests: mptcp: userspace pm get addr tests
>
> Documentation/netlink/specs/mptcp_pm.yaml | 3 +-
> net/mptcp/mptcp_pm_gen.c | 7 +-
> net/mptcp/mptcp_pm_gen.h | 2 +-
> net/mptcp/pm.c | 16 ++
> net/mptcp/pm_netlink.c | 26 ++-
> net/mptcp/pm_userspace.c | 177 ++++++++++++++++--
> net/mptcp/protocol.h | 13 ++
> .../testing/selftests/net/mptcp/mptcp_join.sh | 102 ++++++++++
> tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 39 +++-
> 9 files changed, 353 insertions(+), 32 deletions(-)
>
> --
> 2.40.1
>
>
>