[PATCH mptcp-next v6 00/15] add helpers and vars in mptcp_lib.sh

Geliang Tang posted 15 patches 4 months, 1 week ago
Failed in applying to current master (apply log)
tools/testing/selftests/net/mptcp/diag.sh     |  75 ++---
.../selftests/net/mptcp/mptcp_connect.sh      |  31 +-
.../testing/selftests/net/mptcp/mptcp_join.sh | 204 ++++---------
.../testing/selftests/net/mptcp/mptcp_lib.sh  | 264 +++++++++++++++++
.../selftests/net/mptcp/mptcp_sockopt.sh      |  48 +---
.../testing/selftests/net/mptcp/pm_netlink.sh |  48 +---
.../selftests/net/mptcp/simult_flows.sh       |  30 +-
.../selftests/net/mptcp/userspace_pm.sh       | 270 ++++++------------
8 files changed, 464 insertions(+), 506 deletions(-)
[PATCH mptcp-next v6 00/15] add helpers and vars in mptcp_lib.sh
Posted by Geliang Tang 4 months, 1 week ago
v6:
 - rebased with:
 v3 fixes for CURRESTAB
 v5 dump for userspace pm

v5:
 - rebased with "userspace pm enhancements" v13

v4:
 - rebased with "userspace pm enhancements" v12

v3:
 - merge squash-to patch for v2:
 Squash to "selftests: mptcp: add mptcp_lib_ns_* helpers"
 - add a new patch:
 selftests: mptcp: simult flows: define missing vars
 - update patches:
 selftests: mptcp: export event macros in mptcp_lib
 selftests: mptcp: export cin/cout/sin/sout vars
 selftests: mptcp: netlink: fix positions of newline
 - update some commit subjects and commit logs.

v2:
 - add more patches.

Geliang Tang (15):
  selftests: mptcp: add mptcp_lib_evts_* helpers
  selftests: mptcp: userspace: capitalize test_name
  selftests: mptcp: userspace: print colored output
  selftests: mptcp: capitalize ok/fail/skip
  selftests: mptcp: netlink: drop duplicate var ret
  selftests: mptcp: export ret into mptcp_lib
  selftests: mptcp: extract mptcp_lib_check_expected
  selftests: mptcp: export event macros in mptcp_lib
  selftests: mptcp: add mptcp_lib_verify_listener_events
  selftests: mptcp: unify namespace names
  selftests: mptcp: add mptcp_lib_ns_* helpers
  selftests: mptcp: add ss mptcp support checks
  selftests: mptcp: add mptcp_lib_check_tools helper
  selftests: mptcp: add mptcp_lib_cleanup helper
  selftests: mptcp: add mptcp_lib_check_output helper

 tools/testing/selftests/net/mptcp/diag.sh     |  75 ++---
 .../selftests/net/mptcp/mptcp_connect.sh      |  31 +-
 .../testing/selftests/net/mptcp/mptcp_join.sh | 204 ++++---------
 .../testing/selftests/net/mptcp/mptcp_lib.sh  | 264 +++++++++++++++++
 .../selftests/net/mptcp/mptcp_sockopt.sh      |  48 +---
 .../testing/selftests/net/mptcp/pm_netlink.sh |  48 +---
 .../selftests/net/mptcp/simult_flows.sh       |  30 +-
 .../selftests/net/mptcp/userspace_pm.sh       | 270 ++++++------------
 8 files changed, 464 insertions(+), 506 deletions(-)

-- 
2.35.3
Re: [PATCH mptcp-next v6 00/15] add helpers and vars in mptcp_lib.sh
Posted by Geliang Tang 2 months, 2 weeks ago
On Thu, Dec 21, 2023 at 07:31:03PM +0800, Geliang Tang wrote:
> v6:
>  - rebased with:
>  v3 fixes for CURRESTAB
>  v5 dump for userspace pm
> 
> v5:
>  - rebased with "userspace pm enhancements" v13
> 
> v4:
>  - rebased with "userspace pm enhancements" v12
> 
> v3:
>  - merge squash-to patch for v2:
>  Squash to "selftests: mptcp: add mptcp_lib_ns_* helpers"
>  - add a new patch:
>  selftests: mptcp: simult flows: define missing vars
>  - update patches:
>  selftests: mptcp: export event macros in mptcp_lib
>  selftests: mptcp: export cin/cout/sin/sout vars
>  selftests: mptcp: netlink: fix positions of newline
>  - update some commit subjects and commit logs.
> 
> v2:
>  - add more patches.
> 
> Geliang Tang (15):
>   selftests: mptcp: add mptcp_lib_evts_* helpers
>   selftests: mptcp: userspace: capitalize test_name
>   selftests: mptcp: userspace: print colored output
>   selftests: mptcp: capitalize ok/fail/skip
>   selftests: mptcp: netlink: drop duplicate var ret
>   selftests: mptcp: export ret into mptcp_lib
>   selftests: mptcp: extract mptcp_lib_check_expected
>   selftests: mptcp: export event macros in mptcp_lib
>   selftests: mptcp: add mptcp_lib_verify_listener_events
>   selftests: mptcp: unify namespace names
>   selftests: mptcp: add mptcp_lib_ns_* helpers
>   selftests: mptcp: add ss mptcp support checks
>   selftests: mptcp: add mptcp_lib_check_tools helper
>   selftests: mptcp: add mptcp_lib_cleanup helper
>   selftests: mptcp: add mptcp_lib_check_output helper

New version of this series was sent out, please change them as
"Superseded" on Patchwork.

Thanks,
-Geliang

> 
>  tools/testing/selftests/net/mptcp/diag.sh     |  75 ++---
>  .../selftests/net/mptcp/mptcp_connect.sh      |  31 +-
>  .../testing/selftests/net/mptcp/mptcp_join.sh | 204 ++++---------
>  .../testing/selftests/net/mptcp/mptcp_lib.sh  | 264 +++++++++++++++++
>  .../selftests/net/mptcp/mptcp_sockopt.sh      |  48 +---
>  .../testing/selftests/net/mptcp/pm_netlink.sh |  48 +---
>  .../selftests/net/mptcp/simult_flows.sh       |  30 +-
>  .../selftests/net/mptcp/userspace_pm.sh       | 270 ++++++------------
>  8 files changed, 464 insertions(+), 506 deletions(-)
> 
> -- 
> 2.35.3
Re: [PATCH mptcp-next v6 00/15] add helpers and vars in mptcp_lib.sh
Posted by Matthieu Baerts 2 months, 2 weeks ago
Hi Geliang,

On 13/02/2024 05:25, Geliang Tang wrote:
> On Thu, Dec 21, 2023 at 07:31:03PM +0800, Geliang Tang wrote:
>> v6:
>>  - rebased with:
>>  v3 fixes for CURRESTAB
>>  v5 dump for userspace pm
>>
>> v5:
>>  - rebased with "userspace pm enhancements" v13
>>
>> v4:
>>  - rebased with "userspace pm enhancements" v12
>>
>> v3:
>>  - merge squash-to patch for v2:
>>  Squash to "selftests: mptcp: add mptcp_lib_ns_* helpers"
>>  - add a new patch:
>>  selftests: mptcp: simult flows: define missing vars
>>  - update patches:
>>  selftests: mptcp: export event macros in mptcp_lib
>>  selftests: mptcp: export cin/cout/sin/sout vars
>>  selftests: mptcp: netlink: fix positions of newline
>>  - update some commit subjects and commit logs.
>>
>> v2:
>>  - add more patches.
>>
>> Geliang Tang (15):
>>   selftests: mptcp: add mptcp_lib_evts_* helpers
>>   selftests: mptcp: userspace: capitalize test_name
>>   selftests: mptcp: userspace: print colored output
>>   selftests: mptcp: capitalize ok/fail/skip
>>   selftests: mptcp: netlink: drop duplicate var ret
>>   selftests: mptcp: export ret into mptcp_lib
>>   selftests: mptcp: extract mptcp_lib_check_expected
>>   selftests: mptcp: export event macros in mptcp_lib
>>   selftests: mptcp: add mptcp_lib_verify_listener_events
>>   selftests: mptcp: unify namespace names
>>   selftests: mptcp: add mptcp_lib_ns_* helpers
>>   selftests: mptcp: add ss mptcp support checks
>>   selftests: mptcp: add mptcp_lib_check_tools helper
>>   selftests: mptcp: add mptcp_lib_cleanup helper
>>   selftests: mptcp: add mptcp_lib_check_output helper
> 
> New version of this series was sent out, please change them as
> "Superseded" on Patchwork.

Thank you for the notification!

Sorry, I'm taking a long time to do the review. But I will do it.
Because I took so long to finish it, I can do the rebase of the other
patches if you prefer, that's the least I can do.

I marked patches 5/15 and 12/15 as superseded. Best to not mark them all
like that if the new version is not published.

Should I "drop" others?

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.
Re: [PATCH mptcp-next v6 00/15] add helpers and vars in mptcp_lib.sh
Posted by Geliang Tang 2 months, 2 weeks ago
Hi Matt,

On Tue, Feb 13, 2024 at 01:02:42PM +0100, Matthieu Baerts wrote:
> Hi Geliang,
> 
> On 13/02/2024 05:25, Geliang Tang wrote:
> > On Thu, Dec 21, 2023 at 07:31:03PM +0800, Geliang Tang wrote:
> >> v6:
> >>  - rebased with:
> >>  v3 fixes for CURRESTAB
> >>  v5 dump for userspace pm
> >>
> >> v5:
> >>  - rebased with "userspace pm enhancements" v13
> >>
> >> v4:
> >>  - rebased with "userspace pm enhancements" v12
> >>
> >> v3:
> >>  - merge squash-to patch for v2:
> >>  Squash to "selftests: mptcp: add mptcp_lib_ns_* helpers"
> >>  - add a new patch:
> >>  selftests: mptcp: simult flows: define missing vars
> >>  - update patches:
> >>  selftests: mptcp: export event macros in mptcp_lib
> >>  selftests: mptcp: export cin/cout/sin/sout vars
> >>  selftests: mptcp: netlink: fix positions of newline
> >>  - update some commit subjects and commit logs.
> >>
> >> v2:
> >>  - add more patches.
> >>
> >> Geliang Tang (15):
> >>   selftests: mptcp: add mptcp_lib_evts_* helpers
> >>   selftests: mptcp: userspace: capitalize test_name
> >>   selftests: mptcp: userspace: print colored output
> >>   selftests: mptcp: capitalize ok/fail/skip
> >>   selftests: mptcp: netlink: drop duplicate var ret
> >>   selftests: mptcp: export ret into mptcp_lib
> >>   selftests: mptcp: extract mptcp_lib_check_expected
> >>   selftests: mptcp: export event macros in mptcp_lib
> >>   selftests: mptcp: add mptcp_lib_verify_listener_events
> >>   selftests: mptcp: unify namespace names
> >>   selftests: mptcp: add mptcp_lib_ns_* helpers
> >>   selftests: mptcp: add ss mptcp support checks
> >>   selftests: mptcp: add mptcp_lib_check_tools helper
> >>   selftests: mptcp: add mptcp_lib_cleanup helper
> >>   selftests: mptcp: add mptcp_lib_check_output helper
> > 
> > New version of this series was sent out, please change them as
> > "Superseded" on Patchwork.
> 
> Thank you for the notification!
> 
> Sorry, I'm taking a long time to do the review. But I will do it.
> Because I took so long to finish it, I can do the rebase of the other
> patches if you prefer, that's the least I can do.

Sorry, I put too many patches into one series. This makes the review
difficult. This time I'll split them into smaller series to make the
review simpler.

> 
> I marked patches 5/15 and 12/15 as superseded. Best to not mark them all
> like that if the new version is not published.
> 
> Should I "drop" others?

We can "drop" them in this series. New version is very different from
this one.

Thanks,
-Geliang

> 
> Cheers,
> Matt
> -- 
> Sponsored by the NGI0 Core fund.
Re: [PATCH mptcp-next v6 00/15] add helpers and vars in mptcp_lib.sh
Posted by Matthieu Baerts 2 months, 2 weeks ago
On 13/02/2024 14:58, Geliang Tang wrote:
> Hi Matt,
> 
> On Tue, Feb 13, 2024 at 01:02:42PM +0100, Matthieu Baerts wrote:
>> Hi Geliang,
>>
>> On 13/02/2024 05:25, Geliang Tang wrote:
>>> On Thu, Dec 21, 2023 at 07:31:03PM +0800, Geliang Tang wrote:
>>>> v6:
>>>>  - rebased with:
>>>>  v3 fixes for CURRESTAB
>>>>  v5 dump for userspace pm
>>>>
>>>> v5:
>>>>  - rebased with "userspace pm enhancements" v13
>>>>
>>>> v4:
>>>>  - rebased with "userspace pm enhancements" v12
>>>>
>>>> v3:
>>>>  - merge squash-to patch for v2:
>>>>  Squash to "selftests: mptcp: add mptcp_lib_ns_* helpers"
>>>>  - add a new patch:
>>>>  selftests: mptcp: simult flows: define missing vars
>>>>  - update patches:
>>>>  selftests: mptcp: export event macros in mptcp_lib
>>>>  selftests: mptcp: export cin/cout/sin/sout vars
>>>>  selftests: mptcp: netlink: fix positions of newline
>>>>  - update some commit subjects and commit logs.
>>>>
>>>> v2:
>>>>  - add more patches.
>>>>
>>>> Geliang Tang (15):
>>>>   selftests: mptcp: add mptcp_lib_evts_* helpers
>>>>   selftests: mptcp: userspace: capitalize test_name
>>>>   selftests: mptcp: userspace: print colored output
>>>>   selftests: mptcp: capitalize ok/fail/skip
>>>>   selftests: mptcp: netlink: drop duplicate var ret
>>>>   selftests: mptcp: export ret into mptcp_lib
>>>>   selftests: mptcp: extract mptcp_lib_check_expected
>>>>   selftests: mptcp: export event macros in mptcp_lib
>>>>   selftests: mptcp: add mptcp_lib_verify_listener_events
>>>>   selftests: mptcp: unify namespace names
>>>>   selftests: mptcp: add mptcp_lib_ns_* helpers
>>>>   selftests: mptcp: add ss mptcp support checks
>>>>   selftests: mptcp: add mptcp_lib_check_tools helper
>>>>   selftests: mptcp: add mptcp_lib_cleanup helper
>>>>   selftests: mptcp: add mptcp_lib_check_output helper
>>>
>>> New version of this series was sent out, please change them as
>>> "Superseded" on Patchwork.
>>
>> Thank you for the notification!
>>
>> Sorry, I'm taking a long time to do the review. But I will do it.
>> Because I took so long to finish it, I can do the rebase of the other
>> patches if you prefer, that's the least I can do.
> 
> Sorry, I put too many patches into one series. This makes the review
> difficult. This time I'll split them into smaller series to make the
> review simpler.

All good, thank you for your patience!

>> I marked patches 5/15 and 12/15 as superseded. Best to not mark them all
>> like that if the new version is not published.
>>
>> Should I "drop" others?
> 
> We can "drop" them in this series. New version is very different from
> this one.

OK, I just marked the whole series as superseded then.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.