[v5] add MPTCP_MIB_CURRESTAB

[PATCH mptcp-next v5 0/3] add MPTCP_MIB_CURRESTAB

Geliang Tang posted 3 patches 5 months ago

Diff against v1 v2 v3 v4
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1702446832.git.geliang.tang@linux.dev

Maintainers: Matthieu Baerts <matttbe@kernel.org>, Mat Martineau <martineau@kernel.org>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>

net/mptcp/mib.c                               |  1 +
net/mptcp/mib.h                               |  8 +++
net/mptcp/pm_netlink.c                        |  3 +
net/mptcp/protocol.c                          | 56 ++++++++++++-------
net/mptcp/protocol.h                          |  1 +
net/mptcp/subflow.c                           |  2 +-
.../testing/selftests/net/mptcp/mptcp_join.sh | 45 +++++++++++++--
7 files changed, 91 insertions(+), 25 deletions(-)

Expand all Fold all

[PATCH mptcp-next v5 0/3] add MPTCP_MIB_CURRESTAB

Posted by Geliang Tang 5 months ago

v5:
- merge first three patches into one as Paolo suggested.
- drop "EXPORT_SYMBOL_GPL(mptcp_set_state);" as Paolo suggested.

v4:
- rebased.

v3:
- add mptcp_set_state helper

v2:
- use ftrace_regs_get_argument instead of regs_get_kernel_argument to
  fix build warnings reported kernel test robot.

Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/460

Geliang Tang (3):
  mptcp: add mptcp_set_state
  mptcp: use mptcp_set_state
  selftests: mptcp: check CURRESTAB counters

 net/mptcp/mib.c                               |  1 +
 net/mptcp/mib.h                               |  8 +++
 net/mptcp/pm_netlink.c                        |  3 +
 net/mptcp/protocol.c                          | 56 ++++++++++++-------
 net/mptcp/protocol.h                          |  1 +
 net/mptcp/subflow.c                           |  2 +-
 .../testing/selftests/net/mptcp/mptcp_join.sh | 45 +++++++++++++--
 7 files changed, 91 insertions(+), 25 deletions(-)

-- 
2.35.3

Re: [PATCH mptcp-next v5 0/3] add MPTCP_MIB_CURRESTAB

Posted by Matthieu Baerts 5 months ago

Hi Geliang, Paolo,

On 13/12/2023 06:56, Geliang Tang wrote:
> v5:
> - merge first three patches into one as Paolo suggested.
> - drop "EXPORT_SYMBOL_GPL(mptcp_set_state);" as Paolo suggested.

Thank you for the new version and the reviews!

I just applied it as is in our tree (feat. for net-next), with just a
few modifications in the commit messages (s/connectin/connection/ in
patch 3, moved the "Closes" tag from patch 1 to patch 2 and added
Paolo's ACK and my RvB tags):

New patches for t/upstream:
- 2392f842bb49: mptcp: add mptcp_set_state
- d2b2599f8558: mptcp: use mptcp_set_state
- a4a27026e6f7: selftests: mptcp: check CURRESTAB counters
- Results: bfda5dfb6a94..68bf16e584a7 (export)

Tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20231213T115101

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

Re: [PATCH mptcp-next v5 0/3] add MPTCP_MIB_CURRESTAB

Posted by Paolo Abeni 5 months ago

On Wed, 2023-12-13 at 13:56 +0800, Geliang Tang wrote:
> v5:
> - merge first three patches into one as Paolo suggested.
> - drop "EXPORT_SYMBOL_GPL(mptcp_set_state);" as Paolo suggested.
> 
> v4:
> - rebased.
> 
> v3:
> - add mptcp_set_state helper
> 
> v2:
> - use ftrace_regs_get_argument instead of regs_get_kernel_argument to
>   fix build warnings reported kernel test robot.
> 
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/460
> 
> Geliang Tang (3):
>   mptcp: add mptcp_set_state
>   mptcp: use mptcp_set_state
>   selftests: mptcp: check CURRESTAB counters
> 
>  net/mptcp/mib.c                               |  1 +
>  net/mptcp/mib.h                               |  8 +++
>  net/mptcp/pm_netlink.c                        |  3 +
>  net/mptcp/protocol.c                          | 56 ++++++++++++-------
>  net/mptcp/protocol.h                          |  1 +
>  net/mptcp/subflow.c                           |  2 +-
>  .../testing/selftests/net/mptcp/mptcp_join.sh | 45 +++++++++++++--
>  7 files changed, 91 insertions(+), 25 deletions(-)
> 
LGTM, thanks!

Acked-by: Paolo Abeni <pabeni@redhat.com>