export helpers to mptcp_lib.sh

[PATCH mptcp-next v4 0/7] export helpers to mptcp_lib.sh

Geliang Tang posted 7 patches 6 months, 2 weeks ago

Download series mbox

Failed in applying to current master (apply log)

Maintainers: Matthieu Baerts <matttbe@kernel.org>, Mat Martineau <martineau@kernel.org>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>

tools/testing/selftests/net/mptcp/diag.sh     |  23 +--
.../selftests/net/mptcp/mptcp_connect.sh      | 110 +++----------
.../testing/selftests/net/mptcp/mptcp_join.sh | 146 ++++++------------
.../testing/selftests/net/mptcp/mptcp_lib.sh  |  82 ++++++++++
.../selftests/net/mptcp/mptcp_sockopt.sh      |  39 +----
.../selftests/net/mptcp/simult_flows.sh       |  19 +--
.../selftests/net/mptcp/userspace_pm.sh       |  43 ++----
7 files changed, 170 insertions(+), 292 deletions(-)

Expand all Fold all

[PATCH mptcp-next v4 0/7] export helpers to mptcp_lib.sh

Posted by Geliang Tang 6 months, 2 weeks ago

v4:
 - address Matt's comments in "userspace pm enhancements" v3.

Geliang Tang (7):
  selftests: mptcp: add mptcp_lib_kill_wait
  selftests: mptcp: add mptcp_lib_is_v6
  selftests: mptcp: add mptcp_lib_get_counter
  selftests: mptcp: add missing oflag=append
  selftests: mptcp: add mptcp_lib_make_file
  selftests: mptcp: add mptcp_lib_check_transfer
  selftests: mptcp: add mptcp_lib_wait_local_port_listen

 tools/testing/selftests/net/mptcp/diag.sh     |  23 +--
 .../selftests/net/mptcp/mptcp_connect.sh      | 110 +++----------
 .../testing/selftests/net/mptcp/mptcp_join.sh | 146 ++++++------------
 .../testing/selftests/net/mptcp/mptcp_lib.sh  |  82 ++++++++++
 .../selftests/net/mptcp/mptcp_sockopt.sh      |  39 +----
 .../selftests/net/mptcp/simult_flows.sh       |  19 +--
 .../selftests/net/mptcp/userspace_pm.sh       |  43 ++----
 7 files changed, 170 insertions(+), 292 deletions(-)

-- 
2.35.3

Re: [PATCH mptcp-next v4 0/7] export helpers to mptcp_lib.sh

Posted by Matthieu Baerts 6 months, 1 week ago

Hi Geliang,

On 13/10/2023 09:44, Geliang Tang wrote:
> v4:
>  - address Matt's comments in "userspace pm enhancements" v3.
> 
> Geliang Tang (7):
>   selftests: mptcp: add mptcp_lib_kill_wait
>   selftests: mptcp: add mptcp_lib_is_v6
>   selftests: mptcp: add mptcp_lib_get_counter

I also had to fix issues reported by shellcheck here.

>   selftests: mptcp: add missing oflag=append
>   selftests: mptcp: add mptcp_lib_make_file

I fixed the typo I mentioned + an issue reported by shellcheck.

>   selftests: mptcp: add mptcp_lib_check_transfer
>   selftests: mptcp: add mptcp_lib_wait_local_port_listen

Same here for shellcheck. Please do not forget to check it for
mptcp_lib.sh file.

Now in our tree:

New patches for t/upstream:
- ec838300161b: selftests: mptcp: add mptcp_lib_kill_wait
- d26bafd10cc7: selftests: mptcp: add mptcp_lib_is_v6
- 658015046fcb: selftests: mptcp: add mptcp_lib_get_counter
- 791d4f09923b: selftests: mptcp: add missing oflag=append
- ef38fe1854bb: selftests: mptcp: add mptcp_lib_make_file
- e7970ee8a1e4: selftests: mptcp: add mptcp_lib_check_transfer
- 9e33f3558049: selftests: mptcp: add mptcp_lib_wait_local_port_listen
- Results: 368681114ab6..6e09c1eb6d4b (export)

Tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20231022T234648

Cheers,
Matt

Re: [PATCH mptcp-next v4 0/7] export helpers to mptcp_lib.sh

Posted by Matthieu Baerts 6 months, 1 week ago

Hi Geliang,

On 13/10/2023 09:44, Geliang Tang wrote:
> v4:
>  - address Matt's comments in "userspace pm enhancements" v3.

Thank you for the new version!

There is just a typo in patch 5/7, but that's OK, I can fix that when
applying the patches.

Reviewed-by: Matthieu Baerts <matttbe@kernel.org>

Cheers,
Matt