Hi Geliang,
On 11/10/2023 15:35, Geliang Tang wrote:
> This patch adds a selftest for userpsace PM to remove id 0 address.
> Use userspace_pm_add_addr() helper to add a id 10 address, then use
> userspace_pm_rm_addr() helper to remove id 0 address.
>
> Signed-off-by: Geliang Tang <geliang.tang@suse.com>
> ---
> .../testing/selftests/net/mptcp/mptcp_join.sh | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh
> index e1304383057c..2233b24687cf 100755
> --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
> +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh
> @@ -3529,6 +3529,31 @@ userspace_tests()
> kill_events_pids
> wait $tests_pid
> fi
> +
> + # userspace pm send RM_ADDR for ID 0
> + if reset_with_events "userspace pm send RM_ADDR for ID 0" &&
> + continue_if mptcp_lib_has_file '/proc/sys/net/mptcp/pm_type'; then
> + set_userspace_pm $ns1
> + pm_nl_set_limits $ns2 1 1
> + speed=10 \
> + run_tests $ns1 $ns2 10.0.1.1 &
> + local tests_pid=$!
> + wait_mpj $ns1
> + userspace_pm_add_addr $ns1 10.0.2.1 10
> + chk_join_nr 1 1 1
> + chk_add_nr 1 1
> + chk_mptcp_info subflows 1 subflows 1
> + chk_subflows_total 2 2
> + chk_mptcp_info add_addr_signal 1 add_addr_accepted 1
> + userspace_pm_rm_addr $ns1 0
If this commands forces the server to send a RM_ADDR to the client and
the client, using the Netlink PM, reacts as expected by closing the
initial subflow ...
> + sleep 0.5
(Maybe move this sleep to userspace_pm_rm_addr()? (even if the best is
to wait for an event...))
> + chk_rm_nr 1 0 invert
> + chk_rst_nr 0 0 invert
> + chk_mptcp_info subflows 1 subflows 1
> + chk_subflows_total 2 2
... should we not have one subflow here? (and one removed subflow with
'chk_rm_nr 1 1 invert')
Or maybe the client doesn't react by removing all subflows linked to the
address ID that is given in the RM_ADDR? In this case, we have another
issue :) (in the Netlink PM). We can create a new ticket if that's
easier not to block this series.
Or do we have an issue with the counter displaying 2 while it should be
1? Or an issue with patch 3/7 not closing the subflow as expected?
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net