Hi Geliang,
On 19/09/2023 06:02, Geliang Tang wrote:
> Some of my patches in ML are conflicted, rebase them into one series.
>
> 1-8: some small cleanups, v2
> 9-10: address #428, add mptcpi_subflows_total
> 11-17: address #379, #391, userspace pm remove id 0 subflow & address, v11
> 18-20: address #403, add refcont for address entry
> 21: add userspace fullmesh tests
> 22-30: seltests cleanups
Thank you for this series, it is useful (and again sorry for the delay
to review them). I will really try to look at them ASAP, hopefully soon.
I had a very quick look.
Please note that patches 14/30 and 16/30 will need to go to -net instead
of net-next. I guess it's OK if the selftests linked to them go to
net-next because I think they depend on new features you are adding
here. I think it should not be an issue to apply these two patches
before (maybe a small conflict with "mptcp: define more local variables
sk" but easy to fix).
One more thing: we should be able to run the last version of the
selftests on older kernels (e.g. v5.15 and v6.1). I think with your
modifications, we are fine (I didn't test and only quickly looked) but
that's something to keep in mind.
(also, I think we will need to invert patches 10/30 and 11/30 because
patch 10/30 depends on helpers introduced in the next patch if I'm not
mistaken)
Good idea to share code via the lib then having multiple copies!
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net