Hi Davide,
On 18/09/2023 10:07, Davide Caratti wrote:
> hello Matthieu
>
> On Sat, Sep 16, 2023 at 1:14 PM Matthieu Baerts
> <matthieu.baerts@tessares.net> wrote:
>>
>> Hi Davide,
>>
> [...]
>> I was looking at applying them but I just noticed quite a few errors and
>> warnings reported by CheckPatch. Do you mind looking at them please?
>>
>>> Davide Caratti (6):
>>> tools: ynl: add uns-admin-perm to genetlink legacy> net: mptcp: convert netlink from small_ops to ops
>>
>> Spaces are used instead of tabs for the indentation in
>> include/uapi/linux/mptcp.h and net/mptcp/pm_netlink.c. This code is
>> removed later but I think it is still best to avoid having many errors
>> reported by the CI when sending them upstream.
>
> yes, and it was unintentional. Will fix that today and resend a v4.
Thanks!
>>> Documentation: netlink: add a YAML spec for mptcp
>>
>> Can you add the path of the new file in the MAINTAINERS file please?
>> Also good to add a small description in the commit message, at least to
>> say that it is supposed to represent the YAML spec as currently
>> available today ("no behaviour change intended").
>
> makes sense,
Thanks!
>>> uapi: mptcp: use header file generated from YAML spec
>>
>> Please add a "*" in the MAINTAINERS file to handle the new one in uapi.
>>
>> Also, I guess we cannot fix:
>>
>> Please use a blank line after function/struct/union/enum declarations
>>
>> in include/uapi/linux/mptcp_pm.h as it is auto-generated. (Maybe we
>> should add a comment about that in the commit message? But maybe it is
>> clear it is auto-generated?)
>
> this can probably be fixed in a follow-up commit for ynl-gen-c tool
> (that includes a tree-wide fix for the uAPI headers, because the issue
> might also affect all headers generated until today). The commit
> message says how we use the tool to generate sources, and the header
> file has the "do not edit" caveat line - that is sufficient IMO.
I understand, thank you for the explanation. This improvement can be
done later if needed.
Fine with the current commit message, only the MAINTAINERS file needs to
be modified in this commit then.
>>> net: mptcp: rename netlink handlers to mptcp_pm_nl_<blah>_{doit,dumpit}
>>> net: mptcp: use policy generated by YAML spec
>>
>> If it is OK to send a v4, please also add Paolo's ACK. I think that what
>> he meant to say but he was apparently only allowed to send acronyms :-D
>
> OK is an acronym as well AFAIK :)
:-)
> thanks for looking at this!
You are welcome!
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net