On Mon, 4 Sep 2023, Geliang Tang wrote:
> v3:
> - store burst in msk->snd_burst instead of in sk_storage.
> - make mptcp_sched_data_set_contexts static.
> - rename mptcp_subflow_ctx_by_pos to bpf_mptcp_subflow_ctx_by_pos, and
> add "__bpf_kfunc" before it.
>
Hi Geliang -
Apologies for the delay on reviewing these. The series looks good to
squash, thanks!
- Mat
> v2:
> - keep sched API unchanged.
> - use bpf_sk_storage_lookup to get snd_burst from BPF context.
> - applied after "add bpf_stale scheduler v3" serise.
>
> v1:
>
> There's a bug in bpf_burst. snd_burst stored in mptcp_burst_storage in
> BPF context is not used. msk->snd_burst is still used in kernel space.
> To fix this, add two new interfaces in mptcp_sched_ops to get and set
> scheduler's paramters from BPF context to kernel space.
>
> Geliang Tang (9):
> Squash to "bpf: Export more bpf_burst related functions"
> Squash to "mptcp: add sched_data helpers"
> Squash to "bpf: Add bpf_mptcp_sched_ops"
> Squash to "selftests/bpf: Add mptcp sched structs"
> Squash to "selftests/bpf: Add bpf_first scheduler"
> Squash to "selftests/bpf: Add bpf_bkup scheduler"
> Squash to "selftests/bpf: Add bpf_rr scheduler"
> Squash to "selftests/bpf: Add bpf_red scheduler"
> Squash to "selftests/bpf: Add bpf_burst scheduler"
>
> net/mptcp/bpf.c | 41 +++++++++++----
> net/mptcp/protocol.h | 6 +--
> net/mptcp/sched.c | 50 ++++++++-----------
> tools/testing/selftests/bpf/bpf_tcp_helpers.h | 5 +-
> .../selftests/bpf/progs/mptcp_bpf_bkup.c | 6 +--
> .../selftests/bpf/progs/mptcp_bpf_burst.c | 30 ++---------
> .../selftests/bpf/progs/mptcp_bpf_first.c | 3 +-
> .../selftests/bpf/progs/mptcp_bpf_red.c | 6 +--
> .../selftests/bpf/progs/mptcp_bpf_rr.c | 9 ++--
> 9 files changed, 70 insertions(+), 86 deletions(-)
>
> --
> 2.35.3
>
>
>