[v3] mptcp: fix another close hang-up

[PATCH MPTCP-next v3 0/2] mptcp: fix another close hang-up

Paolo Abeni posted 2 patches 8 months ago

Diff against v1 v2 v4 v5
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1693560377.git.pabeni@redhat.com

Maintainers: Matthieu Baerts <matthieu.baerts@tessares.net>, Mat Martineau <martineau@kernel.org>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>

There is a newer version of this series

net/mptcp/protocol.c | 122 +++++++++++++++++++++----------------------
net/mptcp/protocol.h |  22 +++++++-
net/mptcp/subflow.c  |   3 +-
3 files changed, 83 insertions(+), 64 deletions(-)

Expand all Fold all

[PATCH MPTCP-next v3 0/2] mptcp: fix another close hang-up

Posted by Paolo Abeni 8 months ago

If the TCP subflows close silently due to timeouts, the msk socket
can hang-up indefinitely.

Implement an additional close timeout triggered with the last subflow
close event and move the msk to TCP_CLOSE when it fires.

Should address issues/430 and issues/431.

v2 -> v3:
 - fix int overlflow in patch 2/2

v1 -> v2:
 - fix timeout timer scheduling in patch 2/2 (timeout never fired on v1)

Paolo Abeni (2):
  mptcp: rename timer related helper to less confusing names
  mptcp: implement connection level timeout.

 net/mptcp/protocol.c | 122 +++++++++++++++++++++----------------------
 net/mptcp/protocol.h |  22 +++++++-
 net/mptcp/subflow.c  |   3 +-
 3 files changed, 83 insertions(+), 64 deletions(-)

-- 
2.41.0

Re: [PATCH MPTCP-next v3 0/2] mptcp: fix another close hang-up

Posted by Paolo Abeni 8 months ago

On Fri, 2023-09-01 at 11:27 +0200, Paolo Abeni wrote:
> If the TCP subflows close silently due to timeouts, the msk socket
> can hang-up indefinitely.
> 
> Implement an additional close timeout triggered with the last subflow
> close event and move the msk to TCP_CLOSE when it fires.
> 
> Should address issues/430 and issues/431.
> 
> v2 -> v3:
>  - fix int overlflow in patch 2/2
> 
> v1 -> v2:
>  - fix timeout timer scheduling in patch 2/2 (timeout never fired on v1)
> 
> Paolo Abeni (2):
>   mptcp: rename timer related helper to less confusing names
>   mptcp: implement connection level timeout.
> 
>  net/mptcp/protocol.c | 122 +++++++++++++++++++++----------------------
>  net/mptcp/protocol.h |  22 +++++++-
>  net/mptcp/subflow.c  |   3 +-
>  3 files changed, 83 insertions(+), 64 deletions(-)

Darn me, scratch this version, it's wrong. I was too hasty. I'm glad we
don't have a 24h ban policy on the mptcp ML ;)

/P