[PATCH mptcp-next v3 0/3] userspace pm remove id 0 subflow & address

Geliang Tang posted 3 patches 11 months, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1692281317.git.geliang.tang@suse.com
Maintainers: Matthieu Baerts <matthieu.baerts@tessares.net>, Mat Martineau <martineau@kernel.org>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>, Kishen Maloor <kishen.maloor@intel.com>, Florian Westphal <fw@strlen.de>
There is a newer version of this series
net/mptcp/pm.c                                |  2 +-
net/mptcp/pm_userspace.c                      | 36 +++++++++++----
.../testing/selftests/net/mptcp/mptcp_join.sh | 46 +++++++++++++++++++
3 files changed, 74 insertions(+), 10 deletions(-)
[PATCH mptcp-next v3 0/3] userspace pm remove id 0 subflow & address
Posted by Geliang Tang 11 months, 1 week ago
v3:
 - address Matt's comments in v2.

v2:
 - fix CI errors.

This patchset addresses #379 and #391, add the abilities to remove id 0
subflow and address for userspace PM. And a selftest.

Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/379
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/391

Geliang Tang (3):
  mptcp: allow creating id 0 subflow
  mptcp: remove id 0 address
  selftests: mptcp: remove id 0 subflow & address

 net/mptcp/pm.c                                |  2 +-
 net/mptcp/pm_userspace.c                      | 36 +++++++++++----
 .../testing/selftests/net/mptcp/mptcp_join.sh | 46 +++++++++++++++++++
 3 files changed, 74 insertions(+), 10 deletions(-)

-- 
2.35.3
Re: [PATCH mptcp-next v3 0/3] userspace pm remove id 0 subflow & address
Posted by Matthieu Baerts 11 months, 1 week ago
Hi Geliang,

On 17/08/2023 16:10, Geliang Tang wrote:
> v3:
>  - address Matt's comments in v2.

Thank you for this new version!

I think you forgot to reply to some questions I had in the v2, mainly:
was it OK before this series to remove the initial subflow?

I have other comments, please see the different patches.

Regarding the selftests, it might be good to have 3 different tests:

1) remove the initial subflow: was working before this series but not tested
2) create an additional subflow using the same source IP address as the
initial subflow (ID 0): to validate patch 1/3 from this series
3) send a RM_ADDR for the ID 0: to validate patch 2/3 from this series

For (1) and (2), the test "userspace pm create destroy subflow" could be
modified. Or a new test to cover both at the same time, e.g. to add a
new subflow with local ID 0 and then remove the initial subflow. WDYT?

Note that these 3 tests could also be validated from userspace_pm.sh
instead, no? It maybe makes more sense and would be faster? Up to you.

(also, this series is more for -net (mptcp-net) than net-next)

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net