Hi Geliang,
On 17/08/2023 16:10, Geliang Tang wrote:
> v3:
> - address Matt's comments in v2.
Thank you for this new version!
I think you forgot to reply to some questions I had in the v2, mainly:
was it OK before this series to remove the initial subflow?
I have other comments, please see the different patches.
Regarding the selftests, it might be good to have 3 different tests:
1) remove the initial subflow: was working before this series but not tested
2) create an additional subflow using the same source IP address as the
initial subflow (ID 0): to validate patch 1/3 from this series
3) send a RM_ADDR for the ID 0: to validate patch 2/3 from this series
For (1) and (2), the test "userspace pm create destroy subflow" could be
modified. Or a new test to cover both at the same time, e.g. to add a
new subflow with local ID 0 and then remove the initial subflow. WDYT?
Note that these 3 tests could also be validated from userspace_pm.sh
instead, no? It maybe makes more sense and would be faster? Up to you.
(also, this series is more for -net (mptcp-net) than net-next)
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net