[v2] userspace pm remove id 0 subflow & address

[PATCH mptcp-next v2 0/4] userspace pm remove id 0 subflow & address

Geliang Tang posted 4 patches 8 months, 3 weeks ago

Diff against v1 v1 v3 v4 v5 v6 v7 v8 v9 v10 v11 v12 v13 v14 v15 v16 v17
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1691564649.git.geliang.tang@suse.com

Maintainers: Matthieu Baerts <matthieu.baerts@tessares.net>, Mat Martineau <martineau@kernel.org>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>, Florian Westphal <fw@strlen.de>, Kishen Maloor <kishen.maloor@intel.com>

There is a newer version of this series

net/mptcp/pm_userspace.c                      | 46 ++++++++++++++---
.../testing/selftests/net/mptcp/mptcp_join.sh | 49 +++++++++++++++++++
tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 32 +++++++++++-
3 files changed, 119 insertions(+), 8 deletions(-)

Expand all Fold all

[PATCH mptcp-next v2 0/4] userspace pm remove id 0 subflow & address

Posted by Geliang Tang 8 months, 3 weeks ago

v2:
 - fix CI errors.

This patchset addresses #379 and #391, add the abilities to remove id 0
subflow and address for userspace PM. And a selftest.

Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/379
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/391

Geliang Tang (4):
  mptcp: allow creating id 0 subflow
  mptcp: remove id 0 subflow & address
  selftests: mptcp: add id argument for dsf
  selftests: mptcp: remove id 0 subflow & address

 net/mptcp/pm_userspace.c                      | 46 ++++++++++++++---
 .../testing/selftests/net/mptcp/mptcp_join.sh | 49 +++++++++++++++++++
 tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 32 +++++++++++-
 3 files changed, 119 insertions(+), 8 deletions(-)

-- 
2.35.3

Re: [PATCH mptcp-next v2 0/4] userspace pm remove id 0 subflow & address

Posted by Matthieu Baerts 8 months, 2 weeks ago

Hi Geliang,

On 09/08/2023 09:06, Geliang Tang wrote:
> v2:
>  - fix CI errors.
> 
> This patchset addresses #379 and #391, add the abilities to remove id 0
> subflow and address for userspace PM. And a selftest.
> 
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/379
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/391

Thank you for these patches!

The code of the first one looks good to me, same for the first part of
patch 2/4. Please see the comments in the individual patches for more
details.

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net