[v3] BPF packet scheduler updates part 3

[PATCH mptcp-next v3 0/6] BPF packet scheduler updates part 3

Geliang Tang posted 6 patches 9 months ago

Diff against v1 v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1691036765.git.geliang.tang@suse.com

Maintainers: Matthieu Baerts <matthieu.baerts@tessares.net>, Mat Martineau <martineau@kernel.org>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Alexei Starovoitov <ast@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, Andrii Nakryiko <andrii@kernel.org>, Martin KaFai Lau <martin.lau@linux.dev>, Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>, John Fastabend <john.fastabend@gmail.com>, KP Singh <kpsingh@kernel.org>, Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>, Mykola Lysenko <mykolal@fb.com>, Shuah Khan <shuah@kernel.org>

net/mptcp/bpf.c                               | 19 ++++----
net/mptcp/protocol.h                          |  6 ---
net/mptcp/sched.c                             |  6 +++
tools/testing/selftests/bpf/bpf_tcp_helpers.h |  3 +-
.../testing/selftests/bpf/prog_tests/mptcp.c  |  1 -
.../selftests/bpf/progs/mptcp_bpf_burst.c     | 43 +++++++++++++++----
6 files changed, 52 insertions(+), 26 deletions(-)

Expand all Fold all

[PATCH mptcp-next v3 0/6] BPF packet scheduler updates part 3

Posted by Geliang Tang 9 months ago

v3:
 - define tcp_rtx_and_write_queues_empty() and sk_stream_memory_free() in
BPF context.

v2:
 - use __always_inline instead of inline.

Some cleanups.

Geliang Tang (6):
  Squash to "mptcp: add sched_data helpers"
  Squash to "bpf: Add bpf_mptcp_sched_kfunc_set"
  Squash to "selftests/bpf: add two mptcp netns helpers"
  Squash to "selftests/bpf: Add bpf_rr scheduler"
  Squash to "bpf: Export more bpf_burst related functions"
  Squash to "selftests/bpf: Add bpf_burst scheduler"

 net/mptcp/bpf.c                               | 19 ++++----
 net/mptcp/protocol.h                          |  6 ---
 net/mptcp/sched.c                             |  6 +++
 tools/testing/selftests/bpf/bpf_tcp_helpers.h |  3 +-
 .../testing/selftests/bpf/prog_tests/mptcp.c  |  1 -
 .../selftests/bpf/progs/mptcp_bpf_burst.c     | 43 +++++++++++++++----
 6 files changed, 52 insertions(+), 26 deletions(-)

-- 
2.35.3

Re: [PATCH mptcp-next v3 0/6] BPF packet scheduler updates part 3

Posted by Mat Martineau 8 months, 3 weeks ago

On Thu, 3 Aug 2023, Geliang Tang wrote:

> v3:
> - define tcp_rtx_and_write_queues_empty() and sk_stream_memory_free() in
> BPF context.

v3 looks good to squash, thanks Geliang.

- Mat

>
> v2:
> - use __always_inline instead of inline.
>
> Some cleanups.
>
> Geliang Tang (6):
>  Squash to "mptcp: add sched_data helpers"
>  Squash to "bpf: Add bpf_mptcp_sched_kfunc_set"
>  Squash to "selftests/bpf: add two mptcp netns helpers"
>  Squash to "selftests/bpf: Add bpf_rr scheduler"
>  Squash to "bpf: Export more bpf_burst related functions"
>  Squash to "selftests/bpf: Add bpf_burst scheduler"
>
> net/mptcp/bpf.c                               | 19 ++++----
> net/mptcp/protocol.h                          |  6 ---
> net/mptcp/sched.c                             |  6 +++
> tools/testing/selftests/bpf/bpf_tcp_helpers.h |  3 +-
> .../testing/selftests/bpf/prog_tests/mptcp.c  |  1 -
> .../selftests/bpf/progs/mptcp_bpf_burst.c     | 43 +++++++++++++++----
> 6 files changed, 52 insertions(+), 26 deletions(-)
>
> -- 
> 2.35.3
>
>
>

Re: [PATCH mptcp-next v3 0/6] BPF packet scheduler updates part 3

Posted by Matthieu Baerts 8 months, 3 weeks ago

Hi Geliang, Mat,

On 03/08/2023 06:27, Geliang Tang wrote:
> Geliang Tang (6):
>   Squash to "mptcp: add sched_data helpers"
>   Squash to "bpf: Add bpf_mptcp_sched_kfunc_set"
>   Squash to "selftests/bpf: add two mptcp netns helpers"
>   Squash to "selftests/bpf: Add bpf_rr scheduler"
>   Squash to "bpf: Export more bpf_burst related functions"
>   Squash to "selftests/bpf: Add bpf_burst scheduler"

Thank you for the patches and the reviews!

Now in our tree:

New patches for t/upstream:
- a88f3f498b2f: "squashed" patch 1/6 (with conflicts) in "mptcp: add
sched_data helpers"
- 5d8795774463: "squashed" patch 2/6 in "bpf: Add bpf_mptcp_sched_kfunc_set"
- be959ff059e4: "squashed" patch 3/6 in "selftests/bpf: add two mptcp
netns helpers"
- 1736fcc031f4: "squashed" patch 4/6 in "selftests/bpf: Add bpf_rr
scheduler"
- 574847a8b558: "squashed" patch 5/6 in "bpf: Export more bpf_burst
related functions"
- 206993ff5b4f: "squashed" patch 6/6 in "selftests/bpf: Add bpf_burst
scheduler"
- Results: 2d42b08369ef..03fd7c30320a (export)

Tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20230811T205838

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net