mptcp: subflow removal follow-ups

[PATCH mptcp-next 0/2] mptcp: subflow removal follow-ups

Paolo Abeni posted 2 patches 9 months, 2 weeks ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1689834758.git.pabeni@redhat.com

Maintainers: Matthieu Baerts <matthieu.baerts@tessares.net>, Mat Martineau <martineau@kernel.org>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>

net/mptcp/protocol.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)

Expand all Fold all

[PATCH mptcp-next 0/2] mptcp: subflow removal follow-ups

Posted by Paolo Abeni 9 months, 2 weeks ago

A couple of follow-up to the recent refactor.

Patch 1 address the serious issue reported by Christoph/syzkaller.
Patch 2 is just a cleanup.

Anyhow everything is useless untill we fix/revert the tcp induced
mptcp breakage ;)

Paolo Abeni (2):
  Squash-to: "mptcp: avoid unneeded mptcp_token_destroy() call"
  Squash-to: "mptcp: avoid additional __inet_stream_connect() call"

 net/mptcp/protocol.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

-- 
2.41.0

Re: [PATCH mptcp-next 0/2] mptcp: subflow removal follow-ups

Posted by Matthieu Baerts 9 months, 2 weeks ago

Hi Paolo, Christoph,

On 20/07/2023 08:34, Paolo Abeni wrote:
> A couple of follow-up to the recent refactor.
> 
> Patch 1 address the serious issue reported by Christoph/syzkaller.
> Patch 2 is just a cleanup.

@Paolo: Thank you for the fixes!

@Christoph: happy testing :-) (thank you!)
Do we already close some of the new tickets that have been opened two
days ago? (421+)

> Anyhow everything is useless untill we fix/revert the tcp induced
> mptcp breakage ;)

This has been fixed so I can apply these two patches :)

Now in our tree (feat. for net-next):

- 9fea9fa43aca: "squashed" (with conflicts) patch 1/2 in "mptcp: avoid
unneeded mptcp_token_destroy() calls"
- 1a98012d684c: tg:msg: replace commit msg as requested by Paolo
- cf229e670d26: conflict in
t/mptcp-avoid-additional-__inet_stream_connect-call

- 8c64a5490e5e: "squashed" patch 2/2 in "mptcp: avoid additional
__inet_stream_connect() call"
- 04f57dcde15e: tg:msg: adapt commit msg as requested by Paolo
- Results: 6af60b285fa0..528b797b3425 (export)

Tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20230720T190202

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net