v20:
 - #1-#8, only update the commit logs with warnings reported by checkpatch.
 - #10 don't update the tests which needs to be slower than before.

v19:
 - rename to userspace_pm_rm_sf_addr_ns1/2, and call wait_rm_addr and
   wait_rm_sf in them.
 - update chk_mptcp_info.
 - set FAILING_LINKS in run_tests
 - update commit logs.

v18:
 - address Matt's comments in v17
 - switch to key/value instead of positional parameters

v17:
 - rebased on export/20230607T094151

v16:
 - address Matt's comments in v15.
 - the last two patches in v15 is deponed on "selftests: mptcp: skip
 tests when features are not supported", split them into a new series.
 - this series have no conflect with "selftests: mptcp: skip tests when
 features are not supported" now.

v15:
 - fix the failures reported by CI in v14.

v14:
 - rebased to "selftests: mptcp: skip tests when features are not supported".
 - patch 1 "selftests: mptcp: skip tests when features are not
   supported, v2, patches 8-37"

v13:
 - fix all the failures the CI is complaining about with the debug kconfig.
 - rename endpoint_manipulation to pm_nl_set_endpoint.

Geliang Tang (10):
  mptcp: pass addr to mptcp_pm_alloc_anno_list
  selftests: mptcp: test userspace pm out of transfer
  selftests: mptcp: check subflow and addr infos
  selftests: mptcp: set FAILING_LINKS in run_tests
  selftests: mptcp: drop test_linkfail parameter
  selftests: mptcp: drop addr_nr_ns1/2 parameters
  selftests: mptcp: drop sflags parameter
  selftests: mptcp: add pm_nl_set_endpoint helper
  selftests: mptcp: pass fastclose to sflags
  selftests: mptcp: set endpoint out of transfer

 net/mptcp/pm_netlink.c                        |   8 +-
 net/mptcp/pm_userspace.c                      |   2 +-
 net/mptcp/protocol.h                          |   2 +-
 .../testing/selftests/net/mptcp/mptcp_join.sh | 645 +++++++++++-------
 4 files changed, 394 insertions(+), 263 deletions(-)

-- 
2.35.3

Hi Geliang,

On 16/06/2023 09:30, Geliang Tang wrote:
> v20:
>  - #1-#8, only update the commit logs with warnings reported by checkpatch.
>  - #10 don't update the tests which needs to be slower than before.
> 
> v19:
>  - rename to userspace_pm_rm_sf_addr_ns1/2, and call wait_rm_addr and
>    wait_rm_sf in them.
>  - update chk_mptcp_info.
>  - set FAILING_LINKS in run_tests
>  - update commit logs.

Thank you for the new versions! (and sorry for the delay)

The first 8 patches look good to me, just a small request for patch 3/10
but I can also apply a squash-to patch or do the modifications myself
when applying them if that's OK for you.

Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>

For patches 9 and 10/10, I have a few questions, especially for 10/10
where I don't understand why it is needed. Do you mind explaining that
before sending a new version (if needed)?.

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net

Hi Geliang,

On 16/06/2023 09:30, Geliang Tang wrote:
> v20:
>  - #1-#8, only update the commit logs with warnings reported by checkpatch.
>  - #10 don't update the tests which needs to be slower than before.

Thank you for the patches!

The first 8 patches have now been applied in our tree (feat. for
net-next) with my RvB tags and the suggested modifications for patch 3/8.

New patches for t/upstream:
- 311a895fb08b: mptcp: pass addr to mptcp_pm_alloc_anno_list
- 892a2add5178: selftests: mptcp: test userspace pm out of transfer
- 34da8c8c875b: selftests: mptcp: check subflow and addr infos
- 0aadb9475af5: selftests: mptcp: set FAILING_LINKS in run_tests
- b3ec9662b408: selftests: mptcp: drop test_linkfail parameter
- 5380de466d42: selftests: mptcp: drop addr_nr_ns1/2 parameters
- fc162dadad12: selftests: mptcp: drop sflags parameter
- 75bfcf686b7e: selftests: mptcp: add pm_nl_set_endpoint helper
- Results: d937892749f1..bd3628a02b79 (export)

Tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20230620T114901

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net