unify PM interfaces

[PATCH mptcp-next v2 0/4] unify PM interfaces

Geliang Tang posted 4 patches 10 months, 4 weeks ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1685067241.git.geliang.tang@suse.com

Maintainers: Matthieu Baerts <matthieu.baerts@tessares.net>, Mat Martineau <martineau@kernel.org>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>

net/mptcp/pm.c           |  41 +++++++++++-
net/mptcp/pm_netlink.c   | 132 ++++++++++++++++-----------------------
net/mptcp/pm_userspace.c |   3 -
net/mptcp/protocol.h     |   9 ++-
4 files changed, 103 insertions(+), 82 deletions(-)

Expand all Fold all

[PATCH mptcp-next v2 0/4] unify PM interfaces

Posted by Geliang Tang 10 months, 4 weeks ago

v2:
 - address Matt's comments in v1.

Unify the three PM interfaces: get_local_id(),
get_flags_and_ifindex_by_id() and set_flags().

Geliang Tang (4):
  mptcp: export local_address
  mptcp: unify pm get_local_id interfaces
  mptcp: unify pm get_flags_and_ifindex_by_id
  mptcp: unify pm set_flags interfaces

 net/mptcp/pm.c           |  41 +++++++++++-
 net/mptcp/pm_netlink.c   | 132 ++++++++++++++++-----------------------
 net/mptcp/pm_userspace.c |   3 -
 net/mptcp/protocol.h     |   9 ++-
 4 files changed, 103 insertions(+), 82 deletions(-)

-- 
2.35.3

Re: [PATCH mptcp-next v2 0/4] unify PM interfaces

Posted by Matthieu Baerts 10 months, 3 weeks ago

Hi Geliang,

On 26/05/2023 04:16, Geliang Tang wrote:
> v2:
>  - address Matt's comments in v1.
> 
> Unify the three PM interfaces: get_local_id(),
> get_flags_and_ifindex_by_id() and set_flags().
> 
> Geliang Tang (4):
>   mptcp: export local_address
>   mptcp: unify pm get_local_id interfaces
>   mptcp: unify pm get_flags_and_ifindex_by_id
>   mptcp: unify pm set_flags interfaces

Thank you for these patches! Now in our tree (feat. for net-next):

New patches for t/upstream:
- 558812262951: mptcp: export local_address
- 8d31a594a5db: mptcp: unify pm get_local_id interfaces
- a69053aa196c: mptcp: unify pm get_flags_and_ifindex_by_id
- 7488b43424d9: mptcp: unify pm set_flags interfaces
- Results: 3d6d7b126211..d5bf0f97d0f0 (export)

Tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20230531T143030

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net

Re: [PATCH mptcp-next v2 0/4] unify PM interfaces

Posted by Matthieu Baerts 10 months, 3 weeks ago

Hi Geliang,

On 26/05/2023 04:16, Geliang Tang wrote:
> v2:
>  - address Matt's comments in v1.

Thank you for this new version! LGTM!

Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net