[PATCH v2 mptcp-next 0/3] mptcp: add more mibs

Paolo Abeni posted 3 patches 1 year ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1681481877.git.pabeni@redhat.com
Maintainers: Matthieu Baerts <matthieu.baerts@tessares.net>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>
net/mptcp/mib.c                               |   6 +
net/mptcp/mib.h                               |  18 +++
net/mptcp/options.c                           |   5 +-
net/mptcp/pm.c                                |   6 +-
.../testing/selftests/net/mptcp/mptcp_join.sh | 112 +++++++++---------
5 files changed, 91 insertions(+), 56 deletions(-)
[PATCH v2 mptcp-next 0/3] mptcp: add more mibs
Posted by Paolo Abeni 1 year ago
dumb cover letter for CI's sake.

Slould be applied only after the current tree has been crunched
by syzkaller for a little bit, as this will likely change quite
a bit the timings of some critical path, possibly hiding old races
and make more easy to reach other ones

Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/378

v1 -> v2:
 - fix mpj self-tests failures

Paolo Abeni (3):
  mptcp: introduces more address related mibs
  selftests: mptcp: add explicit check for new mibs
  selftests: mptcp: centralize stats dumping

 net/mptcp/mib.c                               |   6 +
 net/mptcp/mib.h                               |  18 +++
 net/mptcp/options.c                           |   5 +-
 net/mptcp/pm.c                                |   6 +-
 .../testing/selftests/net/mptcp/mptcp_join.sh | 112 +++++++++---------
 5 files changed, 91 insertions(+), 56 deletions(-)

-- 
2.39.2
Re: [PATCH v2 mptcp-next 0/3] mptcp: add more mibs
Posted by Matthieu Baerts 1 year ago
Hi Paolo,

On 14/04/2023 16:19, Paolo Abeni wrote:
> dumb cover letter for CI's sake.
> 
> Slould be applied only after the current tree has been crunched
> by syzkaller for a little bit, as this will likely change quite
> a bit the timings of some critical path, possibly hiding old races
> and make more easy to reach other ones
> 
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/378

Thank you for having looked at that!

I have a small request in patch 2/3 (and a question in 1/3 but that's a
detail) if you don't mind.

We can also apply the patches and do the suggested improvement after if
you prefer.

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
Re: [PATCH v2 mptcp-next 0/3] mptcp: add more mibs
Posted by Matthieu Baerts 12 months ago
Hi Paolo,

On 21/04/2023 13:32, Matthieu Baerts wrote:
> Hi Paolo,
> 
> On 14/04/2023 16:19, Paolo Abeni wrote:
>> dumb cover letter for CI's sake.
>>
>> Slould be applied only after the current tree has been crunched
>> by syzkaller for a little bit, as this will likely change quite
>> a bit the timings of some critical path, possibly hiding old races
>> and make more easy to reach other ones
>>
>> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/378
> 
> Thank you for having looked at that!
> 
> I have a small request in patch 2/3 (and a question in 1/3 but that's a
> detail) if you don't mind.
> 
> We can also apply the patches and do the suggested improvement after if
> you prefer.

As discussed at the last weekly meeting, I just applied the patches in
our tree (feat. for net-next) with my RvB (and without a typo):

New patches for t/upstream:
- 11f98962ef03: mptcp: introduces more address related mibs
- ae2301fadbf9: selftests: mptcp: add explicit check for new mibs
- 3001ad5baef7: selftests: mptcp: centralize stats dumping
- Results: 269bb6df6e7f..b2cd747b2dff (export)

Tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20230503T123221

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net