[v7] mptcp: update userspace pm mptcp_info fields

[PATCH mptcp-next v7 0/7] mptcp: update userspace pm mptcp_info fields

Geliang Tang posted 7 patches 1 year ago

Diff against v3 v4 v5 v6
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1681463340.git.geliang.tang@suse.com

Maintainers: Matthieu Baerts <matthieu.baerts@tessares.net>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>

net/mptcp/pm.c                                | 21 ++++++++++---
net/mptcp/pm_netlink.c                        | 27 +++++++++++++----
net/mptcp/pm_userspace.c                      | 30 +++++++++++++++++--
net/mptcp/protocol.h                          |  4 ++-
.../testing/selftests/net/mptcp/mptcp_join.sh | 22 +++++++++++++-
5 files changed, 90 insertions(+), 14 deletions(-)

Expand all Fold all

[PATCH mptcp-next v7 0/7] mptcp: update userspace pm mptcp_info fields

Posted by Geliang Tang 1 year ago

v7:
 - fix userspace_pm.sh errors reported by CI.
 - only remove addrs in mptcp_nl_cmd_remove().

v6:
 - send a RM ADDR from userspace.

v5:
 - fix a memleak error reported by CI.
 - add more delay for userspace pm tests.

v4:
 - add more patches
 - add selftests

v3:
 - update local_addr_used and add_addr_signaled

v2:
 - hold pm locks

Geliang Tang (7):
  mptcp: pass addr to mptcp_pm_alloc_anno_list
  mptcp: only remove addrs in nl_cmd_remove
  mptcp: don't clear userspace pm addr id
  mptcp: add addr into userspace pm list
  mptcp: increase userspace pm add_addr_signaled
  mptcp: update userspace pm subflows
  selftests: mptcp: check userspace mptcp_info

 net/mptcp/pm.c                                | 21 ++++++++++---
 net/mptcp/pm_netlink.c                        | 27 +++++++++++++----
 net/mptcp/pm_userspace.c                      | 30 +++++++++++++++++--
 net/mptcp/protocol.h                          |  4 ++-
 .../testing/selftests/net/mptcp/mptcp_join.sh | 22 +++++++++++++-
 5 files changed, 90 insertions(+), 14 deletions(-)

-- 
2.35.3

Re: [PATCH mptcp-next v7 0/7] mptcp: update userspace pm mptcp_info fields

Posted by Matthieu Baerts 1 year ago

Hi Geliang,

On 14/04/2023 11:11, Geliang Tang wrote:
> v7:
>  - fix userspace_pm.sh errors reported by CI.
>  - only remove addrs in mptcp_nl_cmd_remove().
> 
> v6:
>  - send a RM ADDR from userspace.

Thank you for this new version!

I have a few comments, some from v5 and some new ones.

Sorry to insist about the reason in the commit messages but I think it
is best to have them clear :)

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net