[v3] cleanups for pm listener event tests

[PATCH mptcp-next v3 0/4] cleanups for pm listener event tests

Geliang Tang posted 4 patches 1 year, 5 months ago

Diff against v2
Download series mbox

Failed in applying to current master (apply log)

Maintainers: Mat Martineau <mathew.j.martineau@linux.intel.com>, Matthieu Baerts <matthieu.baerts@tessares.net>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>

.../testing/selftests/net/mptcp/mptcp_join.sh |  78 +++---
.../selftests/net/mptcp/userspace_pm.sh       | 232 ++++++++----------
2 files changed, 138 insertions(+), 172 deletions(-)

Expand all Fold all

[PATCH mptcp-next v3 0/4] cleanups for pm listener event tests

Posted by Geliang Tang 1 year, 5 months ago

v3:
 - fix CI errors in v2.

v2:
 - add make evts global patches

Order of these patches:
  selftests: mptcp: listener test for in-kernel PM
  selftests: mptcp: make evts global in mptcp_join
  selftests: mptcp: listener test for userspace PM
  selftests: mptcp: make evts global in userspace_pm
  selftests: mptcp: enhance userspace pm tests
  mptcp: add pm listener events

Geliang Tang (4):
  selftests: mptcp: make evts global in userspace_pm
  Squash to "selftests: mptcp: listener test for userspace PM"
  selftests: mptcp: make evts global in mptcp_join
  Squash to "selftests: mptcp: listener test for in-kernel PM"

 .../testing/selftests/net/mptcp/mptcp_join.sh |  78 +++---
 .../selftests/net/mptcp/userspace_pm.sh       | 232 ++++++++----------
 2 files changed, 138 insertions(+), 172 deletions(-)

-- 
2.35.3

Re: [PATCH mptcp-next v3 0/4] cleanups for pm listener event tests

Posted by Matthieu Baerts 1 year, 4 months ago

Hi Geliang, Paolo,

On 26/11/2022 14:15, Geliang Tang wrote:
> v3:
>  - fix CI errors in v2.

Thank you for the patches and the reviews!

> v2:
>  - add make evts global patches
> 
> Order of these patches:
>   selftests: mptcp: listener test for in-kernel PM
>   selftests: mptcp: make evts global in mptcp_join
>   selftests: mptcp: listener test for userspace PM
>   selftests: mptcp: make evts global in userspace_pm
>   selftests: mptcp: enhance userspace pm tests
>   mptcp: add pm listener events

Arf, I though the order was from the older to the newest but it was the
opposite. I saw that after having started applying patches :) Hopefully,
I fixed that properly after!

> Geliang Tang (4):
>   selftests: mptcp: make evts global in userspace_pm
>   Squash to "selftests: mptcp: listener test for userspace PM"
>   selftests: mptcp: make evts global in mptcp_join
>   Squash to "selftests: mptcp: listener test for in-kernel PM"

Now in our tree (feat. for net-next) with Paolo's ACK:

New patches for t/upstream:
- ed6d9febb0b2: selftests: mptcp: make evts global in userspace_pm
(applied just before "selftests: mptcp: listener test for userspace PM")
- Results: 392b1b99f540..79547c1065c6 (export)

- 3070d58445cf: "squashed" patch 5/4 in "selftests: mptcp: make evts
global in userspace_pm"
- b9485b47c19b: tg:msg: update commit message

- 79d06eac81fb: "squashed" patch 2/4 in "selftests: mptcp: listener test
for userspace PM"

- 52bc70ea6192: selftests: mptcp: make evts global in mptcp_join
- Results: 79547c1065c6..bc4d825a7fd3 (export)

- 2f4c24bf60f4: "squashed" patch 4/4 in "selftests: mptcp: listener test
for in-kernel PM"
- Results: bc4d825a7fd3..36f5c1632395 (export)

Tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20221128T172446

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net