[PATCH mptcp-next v5 0/4] add pm listener events

Geliang Tang posted 4 patches 2 weeks, 3 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1668662624.git.geliang.tang@suse.com
Maintainers: Mat Martineau <mathew.j.martineau@linux.intel.com>, Matthieu Baerts <matthieu.baerts@tessares.net>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>
include/uapi/linux/mptcp.h                    |  9 ++
net/mptcp/pm_netlink.c                        | 57 ++++++++++++
net/mptcp/protocol.c                          |  3 +
net/mptcp/protocol.h                          |  2 +
.../testing/selftests/net/mptcp/mptcp_join.sh | 65 +++++++++++++-
.../selftests/net/mptcp/userspace_pm.sh       | 89 ++++++++++++++++++-
6 files changed, 221 insertions(+), 4 deletions(-)
[PATCH mptcp-next v5 0/4] add pm listener events
Posted by Geliang Tang 2 weeks, 3 days ago
v5:
- use GFP_KERNEL instead of GFP_ATOMIC in patch 1.
- add the listener event checking in the existing test in patch 4.
- update subjects and commit logs.

v4:
- split the selftests into two patches.
- do some cleanups.

v3:
- add selftests.

v2:
- send created event from mptcp_listen.
- add a new patch, use entry->lsk directly.

Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/313

Geliang Tang (4):
  mptcp: add pm listener events
  selftests: mptcp: enhance userspace pm tests
  selftests: mptcp: listener test for userspace PM
  selftests: mptcp: listener test for in-kernel PM

 include/uapi/linux/mptcp.h                    |  9 ++
 net/mptcp/pm_netlink.c                        | 57 ++++++++++++
 net/mptcp/protocol.c                          |  3 +
 net/mptcp/protocol.h                          |  2 +
 .../testing/selftests/net/mptcp/mptcp_join.sh | 65 +++++++++++++-
 .../selftests/net/mptcp/userspace_pm.sh       | 89 ++++++++++++++++++-
 6 files changed, 221 insertions(+), 4 deletions(-)

-- 
2.35.3
Re: [PATCH mptcp-next v5 0/4] add pm listener events
Posted by Matthieu Baerts 2 weeks, 2 days ago
Hi Geliang, Mat,

On 17/11/2022 06:31, Geliang Tang wrote:
> v5:
> - use GFP_KERNEL instead of GFP_ATOMIC in patch 1.
> - add the listener event checking in the existing test in patch 4.
> - update subjects and commit logs.
> 
> v4:
> - split the selftests into two patches.
> - do some cleanups.
> 
> v3:
> - add selftests.
> 
> v2:
> - send created event from mptcp_listen.
> - add a new patch, use entry->lsk directly.
> 
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/313
> 
> Geliang Tang (4):
>   mptcp: add pm listener events
>   selftests: mptcp: enhance userspace pm tests
>   selftests: mptcp: listener test for userspace PM
>   selftests: mptcp: listener test for in-kernel PM

Thank you for the patches and the reviews!

Now in our tree (feat. for net-next)

New patches for t/upstream:
- a6871c7e014a: mptcp: add pm listener events
- 4aabc20960d4: selftests: mptcp: enhance userspace pm tests
- 83027c9e1d0c: selftests: mptcp: listener test for userspace PM
- e33052bbf56f: selftests: mptcp: listener test for in-kernel PM
- Results: 48478f54612d..077c54d47661 (export)

- e9fa9c5f6951: tg:msg: events are for any MPTCP listener socket
- Results: 077c54d47661..69720c6cd168 (export)

Tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20221118T102434

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
Re: [PATCH mptcp-next v5 0/4] add pm listener events
Posted by Mat Martineau 2 weeks, 2 days ago
On Thu, 17 Nov 2022, Geliang Tang wrote:

> v5:
> - use GFP_KERNEL instead of GFP_ATOMIC in patch 1.
> - add the listener event checking in the existing test in patch 4.
> - update subjects and commit logs.
>

v5 looks good to me (one minor commit message change noted on patch 3, if 
it's ok with Geliang):

Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>

> v4:
> - split the selftests into two patches.
> - do some cleanups.
>
> v3:
> - add selftests.
>
> v2:
> - send created event from mptcp_listen.
> - add a new patch, use entry->lsk directly.
>
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/313
>
> Geliang Tang (4):
>  mptcp: add pm listener events
>  selftests: mptcp: enhance userspace pm tests
>  selftests: mptcp: listener test for userspace PM
>  selftests: mptcp: listener test for in-kernel PM
>
> include/uapi/linux/mptcp.h                    |  9 ++
> net/mptcp/pm_netlink.c                        | 57 ++++++++++++
> net/mptcp/protocol.c                          |  3 +
> net/mptcp/protocol.h                          |  2 +
> .../testing/selftests/net/mptcp/mptcp_join.sh | 65 +++++++++++++-
> .../selftests/net/mptcp/userspace_pm.sh       | 89 ++++++++++++++++++-
> 6 files changed, 221 insertions(+), 4 deletions(-)
>
> -- 
> 2.35.3
>
>
>

--
Mat Martineau
Intel
Re: [PATCH mptcp-next v5 0/4] add pm listener events
Posted by Geliang Tang 2 weeks, 2 days ago
On Thu, Nov 17, 2022 at 05:44:10PM -0800, Mat Martineau wrote:
> On Thu, 17 Nov 2022, Geliang Tang wrote:
> 
> > v5:
> > - use GFP_KERNEL instead of GFP_ATOMIC in patch 1.
> > - add the listener event checking in the existing test in patch 4.
> > - update subjects and commit logs.
> > 
> 
> v5 looks good to me (one minor commit message change noted on patch 3, if
> it's ok with Geliang):

Thanks, I agree. Please help me update this commit message when merging
it.

-Geliang

> 
> Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
> 
> > v4:
> > - split the selftests into two patches.
> > - do some cleanups.
> > 
> > v3:
> > - add selftests.
> > 
> > v2:
> > - send created event from mptcp_listen.
> > - add a new patch, use entry->lsk directly.
> > 
> > Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/313
> > 
> > Geliang Tang (4):
> >  mptcp: add pm listener events
> >  selftests: mptcp: enhance userspace pm tests
> >  selftests: mptcp: listener test for userspace PM
> >  selftests: mptcp: listener test for in-kernel PM
> > 
> > include/uapi/linux/mptcp.h                    |  9 ++
> > net/mptcp/pm_netlink.c                        | 57 ++++++++++++
> > net/mptcp/protocol.c                          |  3 +
> > net/mptcp/protocol.h                          |  2 +
> > .../testing/selftests/net/mptcp/mptcp_join.sh | 65 +++++++++++++-
> > .../selftests/net/mptcp/userspace_pm.sh       | 89 ++++++++++++++++++-
> > 6 files changed, 221 insertions(+), 4 deletions(-)
> > 
> > -- 
> > 2.35.3
> > 
> > 
> > 
> 
> --
> Mat Martineau
> Intel