[PATCH v2 mptcp-next 0/5] mptcp: support for MPC prio exchange

Paolo Abeni posted 5 patches 1 year, 9 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1656925387.git.pabeni@redhat.com
Maintainers: Jakub Kicinski <kuba@kernel.org>, Shuah Khan <shuah@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Mat Martineau <mathew.j.martineau@linux.intel.com>, Eric Dumazet <edumazet@google.com>, Matthieu Baerts <matthieu.baerts@tessares.net>, "David S. Miller" <davem@davemloft.net>
net/mptcp/pm_netlink.c                        | 128 ++++++++++--------
net/mptcp/protocol.c                          |   2 +-
net/mptcp/protocol.h                          |   2 +-
.../testing/selftests/net/mptcp/mptcp_join.sh |  30 ++++
4 files changed, 104 insertions(+), 58 deletions(-)
[PATCH v2 mptcp-next 0/5] mptcp: support for MPC prio exchange
Posted by Paolo Abeni 1 year, 9 months ago
This series introduces the ability to control the MPC subflow for
the in kernel PM.

patch 1 && 2 refactor a bit the endpoint lookup and MP_PRIO generation
code, to simplify the next patch.

patch 3 introduces the new feature quering the backup status of the
endpoint used by the MPC subflow and eventually generating the needed
MP_PRIO option.

Patch 4 is a related cleanup.

v1 -> v2:
  - rebased, and omitted old patch 1 which should go through -net

Paolo Abeni (5):
  mptcp: introduce and use mptcp_pm_send_ack()
  mptcp: address lookup improvements
  mptcp: allow the in kernel PM to set MPC subflow priority
  mptcp: more accurate MPC endpoint tracking
  selftests: mptcp: add MPC backup tests

 net/mptcp/pm_netlink.c                        | 128 ++++++++++--------
 net/mptcp/protocol.c                          |   2 +-
 net/mptcp/protocol.h                          |   2 +-
 .../testing/selftests/net/mptcp/mptcp_join.sh |  30 ++++
 4 files changed, 104 insertions(+), 58 deletions(-)

-- 
2.35.3


Re: [PATCH v2 mptcp-next 0/5] mptcp: support for MPC prio exchange
Posted by Mat Martineau 1 year, 9 months ago
On Mon, 4 Jul 2022, Paolo Abeni wrote:

> This series introduces the ability to control the MPC subflow for
> the in kernel PM.
>
> patch 1 && 2 refactor a bit the endpoint lookup and MP_PRIO generation
> code, to simplify the next patch.
>
> patch 3 introduces the new feature quering the backup status of the
> endpoint used by the MPC subflow and eventually generating the needed
> MP_PRIO option.
>
> Patch 4 is a related cleanup.
>
> v1 -> v2:
>  - rebased, and omitted old patch 1 which should go through -net
>

Thanks Paolo, v2 looks good to me.

Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>

> Paolo Abeni (5):
>  mptcp: introduce and use mptcp_pm_send_ack()
>  mptcp: address lookup improvements
>  mptcp: allow the in kernel PM to set MPC subflow priority
>  mptcp: more accurate MPC endpoint tracking
>  selftests: mptcp: add MPC backup tests
>
> net/mptcp/pm_netlink.c                        | 128 ++++++++++--------
> net/mptcp/protocol.c                          |   2 +-
> net/mptcp/protocol.h                          |   2 +-
> .../testing/selftests/net/mptcp/mptcp_join.sh |  30 ++++
> 4 files changed, 104 insertions(+), 58 deletions(-)
>
> -- 
> 2.35.3
>
>
>

--
Mat Martineau
Intel

Re: [PATCH v2 mptcp-next 0/5] mptcp: support for MPC prio exchange
Posted by Matthieu Baerts 1 year, 9 months ago
Hi Paolo, Mat,

On 04/07/2022 11:14, Paolo Abeni wrote:
> This series introduces the ability to control the MPC subflow for
> the in kernel PM.
> 
> patch 1 && 2 refactor a bit the endpoint lookup and MP_PRIO generation
> code, to simplify the next patch.
> 
> patch 3 introduces the new feature quering the backup status of the
> endpoint used by the MPC subflow and eventually generating the needed
> MP_PRIO option.
> 
> Patch 4 is a related cleanup.

Thank you for the patches and the reviews!

Now in our tree (feat. for net-next) with Mat's RvB tag and without 2
small issues reported by checkpatch.

New patches for t/upstream:
- 063213e73149: mptcp: introduce and use mptcp_pm_send_ack()
- 69bc499efccb: mptcp: address lookup improvements
- 0417a959d55e: mptcp: allow the in kernel PM to set MPC subflow priority
- 084ba8b4dc1a: mptcp: more accurate MPC endpoint tracking
- 267566754670: selftests: mptcp: add MPC backup tests
- Results: c47b82c7b9aa..7d868133e0d9 (export)

Builds and tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20220706T170628
https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net