[v3] mptcp: mp_fail related fixes

[PATCH mptcp-net v3 0/6] mptcp: mp_fail related fixes

Paolo Abeni posted 6 patches 3 years, 3 months ago

Diff against v1 v2 v4 v5
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1655460262.git.pabeni@redhat.com

Maintainers: Geliang Tang <geliangtang@xiaomi.com>, Paolo Abeni <pabeni@redhat.com>, Matthieu Baerts <matthieu.baerts@tessares.net>, "David S. Miller" <davem@davemloft.net>, Mat Martineau <mathew.j.martineau@linux.intel.com>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Geliang Tang <geliang.tang@suse.com>

There is a newer version of this series

net/mptcp/options.c  |   8 +--
net/mptcp/pm.c       |   5 +-
net/mptcp/protocol.c |  57 +++++++++++++++++----
net/mptcp/protocol.h |  25 +++++++--
net/mptcp/subflow.c  | 119 ++++++++++++++++++++++++++++++++++---------
5 files changed, 170 insertions(+), 44 deletions(-)

Expand all Fold all

[PATCH mptcp-net v3 0/6] mptcp: mp_fail related fixes

Posted by Paolo Abeni 3 years, 3 months ago

While cooking a follow-up for "mptcp: invoke MP_FAIL response when
needed" I stumbled upon a few other MP_FAIL related issues hit my
the self-tests while mangling the above.

All the patches for for the -net tree, and should be applied in-order
around to the squashed-to patch.

v2 -> v3:
 - do not schedule mp_fail timeout on closed socket in patch 3/6 (mat) 

v1 -> v2:
 - take care of UaF in mptcp_worker with new patch 6/6

Paolo Abeni (6):
  mptcp: fix error mibs accounting
  mptcp: introduce MAPPING_BAD_CSUM
  Squash-to: "mptcp: invoke MP_FAIL response when needed"
  mptcp: fix shutdown vs fallback race
  mptcp: consistent map handling on failure
  mptcp: fix race on unaccepted mptcp sockets

 net/mptcp/options.c  |   8 +--
 net/mptcp/pm.c       |   5 +-
 net/mptcp/protocol.c |  57 +++++++++++++++++----
 net/mptcp/protocol.h |  25 +++++++--
 net/mptcp/subflow.c  | 119 ++++++++++++++++++++++++++++++++++---------
 5 files changed, 170 insertions(+), 44 deletions(-)

-- 
2.35.3

Re: [PATCH mptcp-net v3 0/6] mptcp: mp_fail related fixes

Posted by Mat Martineau 3 years, 3 months ago

On Fri, 17 Jun 2022, Paolo Abeni wrote:

> While cooking a follow-up for "mptcp: invoke MP_FAIL response when
> needed" I stumbled upon a few other MP_FAIL related issues hit my
> the self-tests while mangling the above.
>
> All the patches for for the -net tree, and should be applied in-order
> around to the squashed-to patch.
>
> v2 -> v3:
> - do not schedule mp_fail timeout on closed socket in patch 3/6 (mat)
>

Thanks for the v3 Paolo. I have a (non-blocking) question for patch 2 and 
a locking concern for patch 6. But for patches 1-5:

Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>

> v1 -> v2:
> - take care of UaF in mptcp_worker with new patch 6/6
>
> Paolo Abeni (6):
>  mptcp: fix error mibs accounting
>  mptcp: introduce MAPPING_BAD_CSUM
>  Squash-to: "mptcp: invoke MP_FAIL response when needed"
>  mptcp: fix shutdown vs fallback race
>  mptcp: consistent map handling on failure
>  mptcp: fix race on unaccepted mptcp sockets
>
> net/mptcp/options.c  |   8 +--
> net/mptcp/pm.c       |   5 +-
> net/mptcp/protocol.c |  57 +++++++++++++++++----
> net/mptcp/protocol.h |  25 +++++++--
> net/mptcp/subflow.c  | 119 ++++++++++++++++++++++++++++++++++---------
> 5 files changed, 170 insertions(+), 44 deletions(-)
>
> -- 
> 2.35.3
>
>
>

--
Mat Martineau
Intel