[v3] mptcp_join userspace pm tests

[PATCH mptcp-next v3 0/5] mptcp_join userspace pm tests

Geliang Tang posted 5 patches 3 years, 3 months ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1655355422.git.geliang.tang@suse.com

Maintainers: Shuah Khan <shuah@kernel.org>, Eric Dumazet <edumazet@google.com>, Matthieu Baerts <matthieu.baerts@tessares.net>, "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, Mat Martineau <mathew.j.martineau@linux.intel.com>, Paolo Abeni <pabeni@redhat.com>

net/mptcp/pm_userspace.c                      |  2 +
.../testing/selftests/net/mptcp/mptcp_join.sh | 82 ++++++++++++++++++-
tools/testing/selftests/net/mptcp/pm_nl_ctl.c |  2 +-
.../selftests/net/mptcp/userspace_pm.sh       | 40 +++++----
4 files changed, 106 insertions(+), 20 deletions(-)

Expand all Fold all

[PATCH mptcp-next v3 0/5] mptcp_join userspace pm tests

Posted by Geliang Tang 3 years, 3 months ago

This patch set adds add address, remove address, create subflow, and
destroy subflow test cases for userspace pm in mptcp_join script.

v3:
 - use MPTCP_INC_STATS instead of __MPTCP_INC_STATS.
 - drop unneeded pm_nl_set_limits.

v2:
 - add more tests in mptcp_join.sh
 - patch 4, add kill_wait helper as Matt suggested.

Geliang Tang (5):
  mptcp: update MIB_RMSUBFLOW in cmd_sf_destroy
  selftests: mptcp: userspace pm address tests
  selftests: mptcp: userspace pm subflow tests
  selftests: mptcp: avoid Terminated messages in userspace_pm
  selftests: mptcp: update pm_nl_ctl usage header

 net/mptcp/pm_userspace.c                      |  2 +
 .../testing/selftests/net/mptcp/mptcp_join.sh | 82 ++++++++++++++++++-
 tools/testing/selftests/net/mptcp/pm_nl_ctl.c |  2 +-
 .../selftests/net/mptcp/userspace_pm.sh       | 40 +++++----
 4 files changed, 106 insertions(+), 20 deletions(-)

-- 
2.35.3

Re: [PATCH mptcp-next v3 0/5] mptcp_join userspace pm tests

Posted by Matthieu Baerts 3 years, 2 months ago

Hi Geliang, Mat,

On 16/06/2022 07:02, Geliang Tang wrote:
> This patch set adds add address, remove address, create subflow, and
> destroy subflow test cases for userspace pm in mptcp_join script.

Thank you for the patches and the reviews!

New patches for t/upstream:
- 577d9f614162: mptcp: update MIB_RMSUBFLOW in cmd_sf_destroy
- e246aad773d9: selftests: mptcp: userspace pm address tests
- 01eef364817f: selftests: mptcp: userspace pm subflow tests
- b1781e4c95ae: selftests: mptcp: avoid Terminated messages in userspace_pm
- cef6c7fc0216: selftests: mptcp: update pm_nl_ctl usage header
- Results: 065936dc9f58..9e30e28df3d9 (export)


Builds and tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20220620T164712
https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net

Re: [PATCH mptcp-next v3 0/5] mptcp_join userspace pm tests

Posted by Mat Martineau 3 years, 3 months ago

On Thu, 16 Jun 2022, Geliang Tang wrote:

> This patch set adds add address, remove address, create subflow, and
> destroy subflow test cases for userspace pm in mptcp_join script.
>
> v3:
> - use MPTCP_INC_STATS instead of __MPTCP_INC_STATS.
> - drop unneeded pm_nl_set_limits.

Thanks Geliang.

Series looks good, with a squash-to request (see patch 3 comment):

Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>

>
> v2:
> - add more tests in mptcp_join.sh
> - patch 4, add kill_wait helper as Matt suggested.
>
> Geliang Tang (5):
>  mptcp: update MIB_RMSUBFLOW in cmd_sf_destroy
>  selftests: mptcp: userspace pm address tests
>  selftests: mptcp: userspace pm subflow tests
>  selftests: mptcp: avoid Terminated messages in userspace_pm
>  selftests: mptcp: update pm_nl_ctl usage header
>
> net/mptcp/pm_userspace.c                      |  2 +
> .../testing/selftests/net/mptcp/mptcp_join.sh | 82 ++++++++++++++++++-
> tools/testing/selftests/net/mptcp/pm_nl_ctl.c |  2 +-
> .../selftests/net/mptcp/userspace_pm.sh       | 40 +++++----
> 4 files changed, 106 insertions(+), 20 deletions(-)
>
> -- 
> 2.35.3
>
>
>

--
Mat Martineau
Intel