[v5] new bpf_mptcp_sock()

[PATCH RESEND mptcp-next v5 0/3] new bpf_mptcp_sock()

Geliang Tang posted 3 patches 2 years, 1 month ago

Diff against v5
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1646320786.git.geliang.tang@suse.com

Maintainers: Jakub Kicinski <kuba@kernel.org>, Matthieu Baerts <matthieu.baerts@tessares.net>, Song Liu <songliubraving@fb.com>, John Fastabend <john.fastabend@gmail.com>, Shuah Khan <shuah@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, "David S. Miller" <davem@davemloft.net>, Yonghong Song <yhs@fb.com>, Mat Martineau <mathew.j.martineau@linux.intel.com>, Andrii Nakryiko <andrii@kernel.org>, Martin KaFai Lau <kafai@fb.com>, KP Singh <kpsingh@kernel.org>, Alexei Starovoitov <ast@kernel.org>

include/linux/bpf.h                           | 20 ++-----
include/linux/btf_ids.h                       |  3 +-
kernel/bpf/verifier.c                         | 20 -------
net/core/filter.c                             | 13 +++++
net/mptcp/bpf.c                               | 52 ++++---------------
.../testing/selftests/bpf/prog_tests/mptcp.c  | 27 ++++++++--
tools/testing/selftests/bpf/progs/mptcp.c     | 22 ++++++++
7 files changed, 73 insertions(+), 84 deletions(-)

Expand all Fold all

[PATCH RESEND mptcp-next v5 0/3] new bpf_mptcp_sock()

Posted by Geliang Tang 2 years, 1 month ago

RESEND:
 - fix the CI Build Failure.
v5:
 - fix incorrect token value
 - verify the token in selftest

v4:
 - define bpf_mptcp_sock_proto as a static function, no longer export
   it in linux/bpf.h

v3:
 - use RET_PTR_TO_BTF_ID_OR_NULL instead of RET_PTR_TO_MPTCP_SOCK_OR_NULL
 - add a new bpf_id BTF_SOCK_TYPE_MPTCP

v2:
 - keep RET_PTR_TO_MPTCP_SOCK_OR_NULL. If we use RET_PTR_TO_BTF_ID_OR_NULL
instead of RET_PTR_TO_MPTCP_SOCK_OR_NULL as Alexei suggested, the
"userspace" tests developed by Nicolas will break.

Geliang Tang (3):
  Squash to "bpf: add 'bpf_mptcp_sock' structure and helper"
  bpf: implement bpf_mptcp_sock()
  selftests: bpf: exercise bpf_mptcp_sock()

 include/linux/bpf.h                           | 20 ++-----
 include/linux/btf_ids.h                       |  3 +-
 kernel/bpf/verifier.c                         | 20 -------
 net/core/filter.c                             | 13 +++++
 net/mptcp/bpf.c                               | 52 ++++---------------
 .../testing/selftests/bpf/prog_tests/mptcp.c  | 27 ++++++++--
 tools/testing/selftests/bpf/progs/mptcp.c     | 22 ++++++++
 7 files changed, 73 insertions(+), 84 deletions(-)

-- 
2.34.1

Re: [PATCH RESEND mptcp-next v5 0/3] new bpf_mptcp_sock()

Posted by Matthieu Baerts 2 years, 1 month ago

Hi Geliang,

On 03/03/2022 16:22, Geliang Tang wrote:
> RESEND:
>  - fix the CI Build Failure.

For the next series, may you bump the version instead of using 'RESEND'.

It would be clearer. Bumping the version is not costly and typically,
'RESEND' means "resending the exact same content, potentially rebased".

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net

Re: [PATCH RESEND mptcp-next v5 0/3] new bpf_mptcp_sock()

Posted by Geliang Tang 2 years, 1 month ago

Matthieu Baerts <matthieu.baerts@tessares.net> 于2022年3月3日周四 23:26写道：
>
> Hi Geliang,
>
> On 03/03/2022 16:22, Geliang Tang wrote:
> > RESEND:
> >  - fix the CI Build Failure.
>
> For the next series, may you bump the version instead of using 'RESEND'.

Sure!

>
> It would be clearer. Bumping the version is not costly and typically,
> 'RESEND' means "resending the exact same content, potentially rebased".
>
> Cheers,
> Matt
> --
> Tessares | Belgium | Hybrid Access Solutions
> www.tessares.net
>