[PATCH v3 mptcp-next 1/3] Squash-to: "mptcp: constify a bunch of of helpers"

Paolo Abeni posted 3 patches 3 years, 12 months ago
Maintainers: "David S. Miller" <davem@davemloft.net>, Mat Martineau <mathew.j.martineau@linux.intel.com>, Jakub Kicinski <kuba@kernel.org>, Matthieu Baerts <matthieu.baerts@tessares.net>
There is a newer version of this series
[PATCH v3 mptcp-next 1/3] Squash-to: "mptcp: constify a bunch of of helpers"
Posted by Paolo Abeni 3 years, 12 months ago
There are a few more helpers that can be const-ified and I missed
in the previous patch, just squash these change into there.

Signed-off-by: Paolo Abeni <pabeni@redhat.com>
---
 net/mptcp/pm_netlink.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index 46346f009485..56f5603c10f2 100644
--- a/net/mptcp/pm_netlink.c
+++ b/net/mptcp/pm_netlink.c
@@ -1289,7 +1289,7 @@ int mptcp_pm_get_flags_and_ifindex_by_id(struct net *net, unsigned int id,
 }
 
 static bool remove_anno_list_by_saddr(struct mptcp_sock *msk,
-				      struct mptcp_addr_info *addr)
+				      const struct mptcp_addr_info *addr)
 {
 	struct mptcp_pm_add_entry *entry;
 
@@ -1304,7 +1304,7 @@ static bool remove_anno_list_by_saddr(struct mptcp_sock *msk,
 }
 
 static bool mptcp_pm_remove_anno_addr(struct mptcp_sock *msk,
-				      struct mptcp_addr_info *addr,
+				      const struct mptcp_addr_info *addr,
 				      bool force)
 {
 	struct mptcp_rm_list list = { .nr = 0 };
-- 
2.34.1


Re: [PATCH v3 mptcp-next 1/3] Squash-to: "mptcp: constify a bunch of of helpers"
Posted by Mat Martineau 3 years, 12 months ago
On Thu, 10 Feb 2022, Paolo Abeni wrote:

> There are a few more helpers that can be const-ified and I missed
> in the previous patch, just squash these change into there.
>

Ok, looks good to squash. Thanks.

-Mat

> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> ---
> net/mptcp/pm_netlink.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
> index 46346f009485..56f5603c10f2 100644
> --- a/net/mptcp/pm_netlink.c
> +++ b/net/mptcp/pm_netlink.c
> @@ -1289,7 +1289,7 @@ int mptcp_pm_get_flags_and_ifindex_by_id(struct net *net, unsigned int id,
> }
>
> static bool remove_anno_list_by_saddr(struct mptcp_sock *msk,
> -				      struct mptcp_addr_info *addr)
> +				      const struct mptcp_addr_info *addr)
> {
> 	struct mptcp_pm_add_entry *entry;
>
> @@ -1304,7 +1304,7 @@ static bool remove_anno_list_by_saddr(struct mptcp_sock *msk,
> }
>
> static bool mptcp_pm_remove_anno_addr(struct mptcp_sock *msk,
> -				      struct mptcp_addr_info *addr,
> +				      const struct mptcp_addr_info *addr,
> 				      bool force)
> {
> 	struct mptcp_rm_list list = { .nr = 0 };
> -- 
> 2.34.1
>
>
>

--
Mat Martineau
Intel