net/mptcp/sockopt.c | 2 ++ tools/testing/selftests/bpf/prog_tests/mptcp.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-)
Fix the mptcp bpf selftest build break. Geliang Tang (2): Squash to "bpf:selftests: add MPTCP test base" mptcp: add SNDTIMEO setsockopt support net/mptcp/sockopt.c | 2 ++ tools/testing/selftests/bpf/prog_tests/mptcp.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) -- 2.34.1
On Tue, 8 Feb 2022, Geliang Tang wrote: > Fix the mptcp bpf selftest build break. > > Geliang Tang (2): > Squash to "bpf:selftests: add MPTCP test base" > mptcp: add SNDTIMEO setsockopt support > > net/mptcp/sockopt.c | 2 ++ > tools/testing/selftests/bpf/prog_tests/mptcp.c | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > -- > 2.34.1 These look good for the export branch. We did talk about SO_SNDTIMEO about a year ago: https://lore.kernel.org/mptcp/5e465bd5f4b3f7e883e09e3f4bc5a566edba045f.camel@redhat.com/ But Paolo's concern there no longer applies, because the socket option changes since then will apply the sndtimeo value to the msk instead of the first subflow. Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com> -- Mat Martineau Intel
On Tue, Feb 08, 2022 at 04:21:04PM -0800, Mat Martineau wrote: > On Tue, 8 Feb 2022, Geliang Tang wrote: > > > Fix the mptcp bpf selftest build break. > > > > Geliang Tang (2): > > Squash to "bpf:selftests: add MPTCP test base" > > mptcp: add SNDTIMEO setsockopt support > > > > net/mptcp/sockopt.c | 2 ++ > > tools/testing/selftests/bpf/prog_tests/mptcp.c | 2 +- > > 2 files changed, 3 insertions(+), 1 deletion(-) > > > > -- > > 2.34.1 > > These look good for the export branch. > > We did talk about SO_SNDTIMEO about a year ago: > https://lore.kernel.org/mptcp/5e465bd5f4b3f7e883e09e3f4bc5a566edba045f.camel@redhat.com/ > > But Paolo's concern there no longer applies, because the socket option > changes since then will apply the sndtimeo value to the msk instead of the > first subflow. > > Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com> > Hi Matt, When you merge the squash-to patch, could you please help me to rename the subject of the original patch from "bpf:selftests: add MPTCP test base" to "bpf: selftests: add MPTCP test base" I think it seems a little strange that there is no space after the colon. And the subject of another patch "bpf:selftests: add bpf_mptcp_sock() verifier tests" needs to be renamed too. In addition, I want to know why these four BPF patches have stayed on the export branch for so long. Are there any functions that have not been completed yet? I wonder if I can help. Thanks, -Geliang > -- > Mat Martineau > Intel >
Hi Geliang, On 09/02/2022 04:10, Geliang Tang wrote: > On Tue, Feb 08, 2022 at 04:21:04PM -0800, Mat Martineau wrote: >> On Tue, 8 Feb 2022, Geliang Tang wrote: >> >>> Fix the mptcp bpf selftest build break. >>> >>> Geliang Tang (2): >>> Squash to "bpf:selftests: add MPTCP test base" >>> mptcp: add SNDTIMEO setsockopt support >>> >>> net/mptcp/sockopt.c | 2 ++ >>> tools/testing/selftests/bpf/prog_tests/mptcp.c | 2 +- >>> 2 files changed, 3 insertions(+), 1 deletion(-) >>> >>> -- >>> 2.34.1 >> >> These look good for the export branch. >> >> We did talk about SO_SNDTIMEO about a year ago: >> https://lore.kernel.org/mptcp/5e465bd5f4b3f7e883e09e3f4bc5a566edba045f.camel@redhat.com/ >> >> But Paolo's concern there no longer applies, because the socket option >> changes since then will apply the sndtimeo value to the msk instead of the >> first subflow. >> >> Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com> >> > > Hi Matt, > > When you merge the squash-to patch, could you please help me to rename the > subject of the original patch from > "bpf:selftests: add MPTCP test base" > to > "bpf: selftests: add MPTCP test base" > I think it seems a little strange that there is no space after the colon. > And the subject of another patch "bpf:selftests: add bpf_mptcp_sock() > verifier tests" needs to be renamed too. I think it should even be: selftests: bpf: (...) I can do the modifications. > In addition, I want to know why these four BPF patches have stayed on the > export branch for so long. Are there any functions that have not been > completed yet? I wonder if I can help. BPF maintainers also wanted a support in BTF [1]. Nicolas -- who worked on these patches up to the v3 when he was doing an internship at Tessares -- wanted to prepare a v4 addressing this comment but he was busy with his uni work. If you have the opportunity to address comments from [1], that would be great! [1] https://lore.kernel.org/netdev/20200922040830.3iis6xiavhvpfq3v@ast-mbp.dhcp.thefacebook.com/ Cheers, Matt -- Tessares | Belgium | Hybrid Access Solutions www.tessares.net
Hi Geliang, Mat, On 09/02/2022 01:21, Mat Martineau wrote: > On Tue, 8 Feb 2022, Geliang Tang wrote: > >> Fix the mptcp bpf selftest build break. >> >> Geliang Tang (2): >> Squash to "bpf:selftests: add MPTCP test base" >> mptcp: add SNDTIMEO setsockopt support >> >> net/mptcp/sockopt.c | 2 ++ >> tools/testing/selftests/bpf/prog_tests/mptcp.c | 2 +- >> 2 files changed, 3 insertions(+), 1 deletion(-) >> >> -- >> 2.34.1 > > These look good for the export branch. > > We did talk about SO_SNDTIMEO about a year ago: > https://lore.kernel.org/mptcp/5e465bd5f4b3f7e883e09e3f4bc5a566edba045f.camel@redhat.com/ > > > But Paolo's concern there no longer applies, because the socket option > changes since then will apply the sndtimeo value to the msk instead of > the first subflow. > > Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com> Thank you for the patches and the reviews! Now in our tree (feat. for net-next) with Mat's RvB tag (on patch 2/2 only): - 9e3b7120da20: "squashed" patch 1/2 in "selftests: bpf: add MPTCP test base" - 0cc76a0dbc16: "Signed-off-by" + "Co-developed-by" - 0e4737981bcc: mptcp: add SNDTIMEO setsockopt support Also renamed the title of two patches: s/bpf:selftests:/selftests: bpf:/ - e93e37b063eb: tg:msg: fix prefix order and space - 0df242af6c98: tg:msg: fix prefix order and space - Results: 56333e0f13bc..3484d41ff4f2 Builds and tests are now in progress: https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20220209T122329 https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export Cheers, Matt -- Tessares | Belgium | Hybrid Access Solutions www.tessares.net
© 2016 - 2024 Red Hat, Inc.