v5:
v4:
 - update the output of pm_netlink.sh

v3:
 - update the usage of set_flags in #1
 - check more of the intermediate states with "pm_nl_ctl dump" in #2

v2:
 - make standalone patches, instead of squash-to ones.
 - add test cases in pm_netlink.sh, instead of mptcp_join.sh

Add the id argument for 'pm_nl_ctl set', and allow to use the port keyword
with the non-signal flags for the setting flags in 'ip mptcp endpoint
change', more commands can be used to set the address flags:

 pm_nl_ctl set 10.0.2.1 flags backup port 10100
 pm_nl_ctl set id 1 flags backup
 ip mptcp endpoint change id 1 backup
 ip mptcp endpoint change 10.0.2.1 backup port 10100

Geliang Tang (2):
  selftests: mptcp: add the id argument for set_flags
  selftests: mptcp: add set_flags tests in pm_netlink.sh

 .../testing/selftests/net/mptcp/pm_netlink.sh | 18 ++++++
 tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 63 ++++++++++++-------
 2 files changed, 60 insertions(+), 21 deletions(-)

-- 
2.31.1

On Wed, 26 Jan 2022, Geliang Tang wrote:

> v5:
> v4:
> - update the output of pm_netlink.sh
>

Thanks for updating, patches look good to me.

Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>

> v3:
> - update the usage of set_flags in #1
> - check more of the intermediate states with "pm_nl_ctl dump" in #2
>
> v2:
> - make standalone patches, instead of squash-to ones.
> - add test cases in pm_netlink.sh, instead of mptcp_join.sh
>
> Add the id argument for 'pm_nl_ctl set', and allow to use the port keyword
> with the non-signal flags for the setting flags in 'ip mptcp endpoint
> change', more commands can be used to set the address flags:
>
> pm_nl_ctl set 10.0.2.1 flags backup port 10100
> pm_nl_ctl set id 1 flags backup
> ip mptcp endpoint change id 1 backup
> ip mptcp endpoint change 10.0.2.1 backup port 10100
>
> Geliang Tang (2):
>  selftests: mptcp: add the id argument for set_flags
>  selftests: mptcp: add set_flags tests in pm_netlink.sh
>
> .../testing/selftests/net/mptcp/pm_netlink.sh | 18 ++++++
> tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 63 ++++++++++++-------
> 2 files changed, 60 insertions(+), 21 deletions(-)
>
> -- 
> 2.31.1
>
>
>

--
Mat Martineau
Intel

Hi Mat, Geliang,

On 26/01/2022 22:45, Mat Martineau wrote:
> On Wed, 26 Jan 2022, Geliang Tang wrote:
> 
>> v5:
>> v4:
>> - update the output of pm_netlink.sh
>>
> 
> Thanks for updating, patches look good to me.
> 
> Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>

Thank you for the patches and the reviews!

Now in our tree (feat. for net-next) with Mat's RvB tag:

- f8e513817b09: selftests: mptcp: add the id argument for set_flags
- ec38992d3ed7: selftests: mptcp: add set_flags tests in pm_netlink.sh
- Results: d57649f20e6e..6cf1fda75aaf

Builds and tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20220128T170856
https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net