v2:
 - use a mask of changed flags as Mat suggested.
 - squash patch 8 and patch 9 in v1 into one.

Geliang Tang (10):
  mptcp: set fullmesh flag in pm_netlink
  selftests: mptcp: set fullmesh flag in pm_nl_ctl
  selftests: mptcp: add fullmesh setting tests
  mptcp: allow to use port and non-signal in set_flags
  selftests: mptcp: add the port argument for set_flags
  selftests: mptcp: add backup with port testcase
  selftests: mptcp: add ip mptcp wrappers
  selftests: mptcp: add wrapper for showing addrs
  selftests: mptcp: add wrapper for setting flags
  selftests: mptcp: set ip_mptcp in command line

 net/mptcp/pm_netlink.c                        |  50 +-
 .../testing/selftests/net/mptcp/mptcp_join.sh | 936 +++++++++++-------
 tools/testing/selftests/net/mptcp/pm_nl_ctl.c |  19 +-
 3 files changed, 616 insertions(+), 389 deletions(-)

-- 
2.31.1

On Sun, 16 Jan 2022, Geliang Tang wrote:

> v2:
> - use a mask of changed flags as Mat suggested.
> - squash patch 8 and patch 9 in v1 into one.
>

v2 looks ready for the export branch, thanks Geliang.

Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>


> Geliang Tang (10):
>  mptcp: set fullmesh flag in pm_netlink
>  selftests: mptcp: set fullmesh flag in pm_nl_ctl
>  selftests: mptcp: add fullmesh setting tests
>  mptcp: allow to use port and non-signal in set_flags
>  selftests: mptcp: add the port argument for set_flags
>  selftests: mptcp: add backup with port testcase
>  selftests: mptcp: add ip mptcp wrappers
>  selftests: mptcp: add wrapper for showing addrs
>  selftests: mptcp: add wrapper for setting flags
>  selftests: mptcp: set ip_mptcp in command line
>
> net/mptcp/pm_netlink.c                        |  50 +-
> .../testing/selftests/net/mptcp/mptcp_join.sh | 936 +++++++++++-------
> tools/testing/selftests/net/mptcp/pm_nl_ctl.c |  19 +-
> 3 files changed, 616 insertions(+), 389 deletions(-)
>

--
Mat Martineau
Intel

On Wed, Jan 19, 2022 at 05:01:53PM -0800, Mat Martineau wrote:
> On Sun, 16 Jan 2022, Geliang Tang wrote:
> 
> > v2:
> > - use a mask of changed flags as Mat suggested.
> > - squash patch 8 and patch 9 in v1 into one.
> > 
> 
> v2 looks ready for the export branch, thanks Geliang.
> 
> Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>

Please add Paolo's Acked-by tag for the first three patches.

Thanks,
-Geliang

> 
> 
> > Geliang Tang (10):
> >  mptcp: set fullmesh flag in pm_netlink
> >  selftests: mptcp: set fullmesh flag in pm_nl_ctl
> >  selftests: mptcp: add fullmesh setting tests
> >  mptcp: allow to use port and non-signal in set_flags
> >  selftests: mptcp: add the port argument for set_flags
> >  selftests: mptcp: add backup with port testcase
> >  selftests: mptcp: add ip mptcp wrappers
> >  selftests: mptcp: add wrapper for showing addrs
> >  selftests: mptcp: add wrapper for setting flags
> >  selftests: mptcp: set ip_mptcp in command line
> > 
> > net/mptcp/pm_netlink.c                        |  50 +-
> > .../testing/selftests/net/mptcp/mptcp_join.sh | 936 +++++++++++-------
> > tools/testing/selftests/net/mptcp/pm_nl_ctl.c |  19 +-
> > 3 files changed, 616 insertions(+), 389 deletions(-)
> > 
> 
> --
> Mat Martineau
> Intel
> 

Hi Geliang,

On 20/01/2022 11:20, Geliang Tang wrote:
> On Wed, Jan 19, 2022 at 05:01:53PM -0800, Mat Martineau wrote:
>> On Sun, 16 Jan 2022, Geliang Tang wrote:
>>
>>> v2:
>>> - use a mask of changed flags as Mat suggested.
>>> - squash patch 8 and patch 9 in v1 into one.
>>>
>>
>> v2 looks ready for the export branch, thanks Geliang.
>>
>> Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
> 
> Please add Paolo's Acked-by tag for the first three patches.

Thank you, I will add the Acked-by tag and also directly apply the 3
squash-to patches you sent, they are OK for me and fixing issues.

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net

Hi Geliang, Mat, Paolo,

On 16/01/2022 09:17, Geliang Tang wrote:
> v2:
>  - use a mask of changed flags as Mat suggested.
>  - squash patch 8 and patch 9 in v1 into one.
> 
> Geliang Tang (10):
>   mptcp: set fullmesh flag in pm_netlink
>   selftests: mptcp: set fullmesh flag in pm_nl_ctl
>   selftests: mptcp: add fullmesh setting tests
>   mptcp: allow to use port and non-signal in set_flags
>   selftests: mptcp: add the port argument for set_flags
>   selftests: mptcp: add backup with port testcase
>   selftests: mptcp: add ip mptcp wrappers
>   selftests: mptcp: add wrapper for showing addrs
>   selftests: mptcp: add wrapper for setting flags
>   selftests: mptcp: set ip_mptcp in command line

Thank you for the patches and the reviews!

Just applied in our tree (feat. for net-next) with Mat's RvB and Paolo's
ACK (on the 3 first ones only) tags and without typos spot by
checkpatch.pl --codespell (see patchwork for the details)

- b705fd7215b9: mptcp: set fullmesh flag in pm_netlink
- 6217aef203f5: selftests: mptcp: set fullmesh flag in pm_nl_ctl
- 158dc9a65aa3: selftests: mptcp: add fullmesh setting tests
- 3e710d18759c: mptcp: allow to use port and non-signal in set_flags
- 61fe48d3c297: selftests: mptcp: add the port argument for set_flags
- bd2761b79d26: selftests: mptcp: add backup with port testcase
- 58972f3b5692: selftests: mptcp: add ip mptcp wrappers
- cc944025a862: selftests: mptcp: add wrapper for showing addrs
- 94b163441224: selftests: mptcp: add wrapper for setting flags
- 5627a6a4a066: selftests: mptcp: set ip_mptcp in command line
- Results: fbaefb5453f9..88ed28f981da

I also applied the 3 squash-to patches linked to this series:

- f6b3ae3ddda1: "squashed" in "selftests: mptcp: set fullmesh flag in
pm_nl_ctl"
- 797bceadf4f5: "squashed" in "selftests: mptcp: add backup with port
testcase"
- 955e2784c04e: conflict in t/selftests-mptcp-add-wrapper-for-setting-flags
- dbd4ae0f794f: "squashed" in "selftests: mptcp: add wrapper for setting
flags"
- Results: 88ed28f981da..e974a42412b3

Builds and tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20220120T150402
https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net