[PATCH mptcp-next v5 0/5] use 'ip mptcp' in selftests

Geliang Tang posted 5 patches 1 week, 4 days ago
Failed in applying to current master (apply log)
.../testing/selftests/net/mptcp/mptcp_join.sh | 878 ++++++++++--------
1 file changed, 502 insertions(+), 376 deletions(-)

[PATCH mptcp-next v5 0/5] use 'ip mptcp' in selftests

Posted by Geliang Tang 1 week, 4 days ago
v5:
 - init _port in patch 4, otherwise it will be a random number in some
   tests.
 - depends on:
 the "set_flags port support" series.

v4:
 - move the patch "new approach of getting addr" into "set_flags port
 support" series.
 - rebased with "set_flags port support" series.

RESEND:
 - update subjects and commit messages.
 - rename pm_nl_show_endpoint to pm_nl_show_endpoints.
v3:
 - use new approach of getting addr.
 - squash four patches, pm_nl_set_limits, pm_nl_add_endpoint,
 pm_nl_del_endpoint and pm_nl_flush_endpoint, into one.
 - rebased, fix conflicts.
 - depends on:
 the "fullmesh flag setting support" series.

RESEND:
 - fix typos and checkpatch.pl warnings.
v2:
 - use both ip_mptcp and pm_nl_ctl in mptcp_join.sh, instead of
   replaceing pm_nl_ctl in v1.
 - drop last three patches in v1, keep using pm_nl_ctl in
   mptcp_sockopt.sh, pm_netlink.sh and simult_flows.sh

v1:
 This patchset replaced all the pm_nl_ctl commands in selftests with the
 'ip mptcp' commands.

Geliang Tang (5):
  selftests: mptcp: add ip mptcp wrappers
  selftests: mptcp: new approach of getting ID
  selftests: mptcp: add wrapper for showing addrs
  selftests: mptcp: add wrapper for setting flags
  selftests: mptcp: set ip_mptcp in command line

 .../testing/selftests/net/mptcp/mptcp_join.sh | 878 ++++++++++--------
 1 file changed, 502 insertions(+), 376 deletions(-)

-- 
2.31.1


Re: [PATCH mptcp-next v5 0/5] use 'ip mptcp' in selftests

Posted by Mat Martineau 1 week, 4 days ago
On Thu, 13 Jan 2022, Geliang Tang wrote:

> v5:
> - init _port in patch 4, otherwise it will be a random number in some
>   tests.
> - depends on:
> the "set_flags port support" series.

Hi Geliang -

I appreciate that you were trying to make the patchset dependencies more 
obvious by threading this patch set under "set_flags port support". 
However, it seems like all the tools (patchew, b4, my email client's 
threading) didn't handle it well :)

I think it's better to keep the series separate and comment in the cover 
letters about the dependencies, or merge them in to one big series that 
patchew/b4/etc can understand.

Thanks!

Mat


>
> v4:
> - move the patch "new approach of getting addr" into "set_flags port
> support" series.
> - rebased with "set_flags port support" series.
>
> RESEND:
> - update subjects and commit messages.
> - rename pm_nl_show_endpoint to pm_nl_show_endpoints.
> v3:
> - use new approach of getting addr.
> - squash four patches, pm_nl_set_limits, pm_nl_add_endpoint,
> pm_nl_del_endpoint and pm_nl_flush_endpoint, into one.
> - rebased, fix conflicts.
> - depends on:
> the "fullmesh flag setting support" series.
>
> RESEND:
> - fix typos and checkpatch.pl warnings.
> v2:
> - use both ip_mptcp and pm_nl_ctl in mptcp_join.sh, instead of
>   replaceing pm_nl_ctl in v1.
> - drop last three patches in v1, keep using pm_nl_ctl in
>   mptcp_sockopt.sh, pm_netlink.sh and simult_flows.sh
>
> v1:
> This patchset replaced all the pm_nl_ctl commands in selftests with the
> 'ip mptcp' commands.
>
> Geliang Tang (5):
>  selftests: mptcp: add ip mptcp wrappers
>  selftests: mptcp: new approach of getting ID
>  selftests: mptcp: add wrapper for showing addrs
>  selftests: mptcp: add wrapper for setting flags
>  selftests: mptcp: set ip_mptcp in command line
>
> .../testing/selftests/net/mptcp/mptcp_join.sh | 878 ++++++++++--------
> 1 file changed, 502 insertions(+), 376 deletions(-)
>
> -- 
> 2.31.1
>
>
>

--
Mat Martineau
Intel