more patches from pm_nl_ctl

[PATCH iproute2-next 0/3] more patches from pm_nl_ctl

Posted by Geliang Tang 2 years, 3 months ago

This patched added id 0 address deleting, fullmesh flag and backup setting
from pm_nl_ctl. With these patches, we can replace all pm_nl_ctl in the
selftests with 'ip mptcp' command.

Geliang Tang (3):
  mptcp: add id check for deleting address
  mptcp: add the addr flag fullmesh
  mptcp: add the backup flag setting

 include/uapi/linux/mptcp.h |  2 ++
 ip/ipmptcp.c               | 31 +++++++++++++++++++++++++------
 2 files changed, 27 insertions(+), 6 deletions(-)

-- 
2.31.1

Re: [PATCH iproute2-next 0/3] more patches from pm_nl_ctl

Posted by Mat Martineau 2 years, 3 months ago

On Tue, 4 Jan 2022, Geliang Tang wrote:

> This patched added id 0 address deleting, fullmesh flag and backup setting
> from pm_nl_ctl. With these patches, we can replace all pm_nl_ctl in the
> selftests with 'ip mptcp' command.
>
> Geliang Tang (3):
>  mptcp: add id check for deleting address
>  mptcp: add the addr flag fullmesh
>  mptcp: add the backup flag setting
>
> include/uapi/linux/mptcp.h |  2 ++
> ip/ipmptcp.c               | 31 +++++++++++++++++++++++++------
> 2 files changed, 27 insertions(+), 6 deletions(-)
>
> -- 
> 2.31.1

Hi Geliang -

I found that this doesn't apply to 
https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git, but it 
does apply to iproute2.git

If you check iproute2-next, there's already a patch in there from Paolo 
that adds the fullmesh flag.

Can you rebase the other two patches on iproute2-next for v2?


Thanks,


--
Mat Martineau
Intel

Re: [PATCH iproute2-next 0/3] more patches from pm_nl_ctl

Posted by Geliang Tang 2 years, 3 months ago

Hi Mat,

Thanks for your review.

On Fri, Jan 07, 2022 at 04:11:43PM -0800, Mat Martineau wrote:
> On Tue, 4 Jan 2022, Geliang Tang wrote:
> 
> > This patched added id 0 address deleting, fullmesh flag and backup setting
> > from pm_nl_ctl. With these patches, we can replace all pm_nl_ctl in the
> > selftests with 'ip mptcp' command.
> > 
> > Geliang Tang (3):
> >  mptcp: add id check for deleting address
> >  mptcp: add the addr flag fullmesh
> >  mptcp: add the backup flag setting
> > 
> > include/uapi/linux/mptcp.h |  2 ++
> > ip/ipmptcp.c               | 31 +++++++++++++++++++++++++------
> > 2 files changed, 27 insertions(+), 6 deletions(-)
> > 
> > -- 
> > 2.31.1
> 
> Hi Geliang -
> 
> I found that this doesn't apply to
> https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git, but it
> does apply to iproute2.git
> 
> If you check iproute2-next, there's already a patch in there from Paolo that
> adds the fullmesh flag.

Yes, v1 was against the wrong repo, not iproute2-next.git.

I just noticed there's already a patch in iproute2-next from Davide that
adds the backup flag setting too:
 "mptcp: add support for changing the backup flag"

So patch 2 and 3 in this series should be dropped.

> 
> Can you rebase the other two patches on iproute2-next for v2?

I only updated patch 1 for v2.

Thanks,
-Geliang

> 
> 
> Thanks,
> 
> 
> --
> Mat Martineau
> Intel
>