[PATCH mptcp-next 0/2] reuse __mptcp_make_csum in validate_data_csum

Geliang Tang posted 2 patches 1 month, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1639722883.git.geliang.tang@suse.com
Maintainers: Jakub Kicinski <kuba@kernel.org>, Mat Martineau <mathew.j.martineau@linux.intel.com>, "David S. Miller" <davem@davemloft.net>, Matthieu Baerts <matthieu.baerts@tessares.net>
net/mptcp/options.c  |  8 ++++----
net/mptcp/protocol.h |  1 +
net/mptcp/subflow.c  | 15 ++++++---------
3 files changed, 11 insertions(+), 13 deletions(-)

[PATCH mptcp-next 0/2] reuse __mptcp_make_csum in validate_data_csum

Posted by Geliang Tang 1 month, 1 week ago
Two cleanup patches for the data checksum.

Geliang Tang (2):
  mptcp: change the parameter of __mptcp_make_csum
  mptcp: reuse __mptcp_make_csum in validate_data_csum

 net/mptcp/options.c  |  8 ++++----
 net/mptcp/protocol.h |  1 +
 net/mptcp/subflow.c  | 15 ++++++---------
 3 files changed, 11 insertions(+), 13 deletions(-)

-- 
2.31.1


Re: [PATCH mptcp-next 0/2] reuse __mptcp_make_csum in validate_data_csum

Posted by Matthieu Baerts 1 month, 1 week ago
Hi Geliang, Mat,

On 17/12/2021 07:38, Geliang Tang wrote:
> Two cleanup patches for the data checksum.
> 
> Geliang Tang (2):
>   mptcp: change the parameter of __mptcp_make_csum
>   mptcp: reuse __mptcp_make_csum in validate_data_csum

Thank you for these patches and reviews!

Now in our tree (feat. for net-next) with Mat's RvB tag:

- 3d0fe9f4a4ff: mptcp: change the parameter of __mptcp_make_csum
- 4990d2f45261: mptcp: reuse __mptcp_make_csum in validate_data_csum
- Results: 079ed80abcff..23b272a3d65a

Builds and tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20211218T090448
https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net

Re: [PATCH mptcp-next 0/2] reuse __mptcp_make_csum in validate_data_csum

Posted by Mat Martineau 1 month, 1 week ago
On Fri, 17 Dec 2021, Geliang Tang wrote:

> Two cleanup patches for the data checksum.
>
> Geliang Tang (2):
>  mptcp: change the parameter of __mptcp_make_csum
>  mptcp: reuse __mptcp_make_csum in validate_data_csum
>
> net/mptcp/options.c  |  8 ++++----
> net/mptcp/protocol.h |  1 +
> net/mptcp/subflow.c  | 15 ++++++---------
> 3 files changed, 11 insertions(+), 13 deletions(-)
>
> -- 
> 2.31.1


Hi Geliang -

Thanks for the cleanup patches! The changes look good to me, and all the 
'mptcp_connect.sh -C' tests work on my system. I tested with only patch 1, 
or both patch 1 & 2, and since both the old and new validation code work 
we can be sure the behavior hasn't changed.

Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>

--
Mat Martineau
Intel