[v1] mptcp: a couple of cleanups

[PATCH mptcp-next 0/2] mptcp: a couple of cleanups

Paolo Abeni posted 2 patches 2 years, 4 months ago

Diff against v1
Download series mbox

Failed in applying to current master (apply log)

There is a newer version of this series

net/mptcp/pm_netlink.c |   3 -
net/mptcp/protocol.c   | 149 ++++++++++++++++++-----------------------
net/mptcp/protocol.h   |  31 ++++-----
net/mptcp/sockopt.c    |  24 ++-----
net/mptcp/subflow.c    |   9 ++-
5 files changed, 89 insertions(+), 127 deletions(-)

Expand all Fold all

[PATCH mptcp-next 0/2] mptcp: a couple of cleanups

Posted by Paolo Abeni 2 years, 4 months ago

The first patch was already shared as RFC, this iteration
addresses a couple of bugs there.

The second patch removes a bunch of conditionals and atomic
operations in the fast path, but the performance impact is
actually below noise level. Still I think it's worthy, as the
unneeded atomic operations are confusing.

Paolo Abeni (2):
  mptcp: cleanup MPJ subflow list handling
  mptcp: avoid atomic bit manipulation when possible

 net/mptcp/pm_netlink.c |   3 -
 net/mptcp/protocol.c   | 149 ++++++++++++++++++-----------------------
 net/mptcp/protocol.h   |  31 ++++-----
 net/mptcp/sockopt.c    |  24 ++-----
 net/mptcp/subflow.c    |   9 ++-
 5 files changed, 89 insertions(+), 127 deletions(-)

-- 
2.33.1

Re: [PATCH mptcp-next 0/2] mptcp: a couple of cleanups

Posted by Mat Martineau 2 years, 4 months ago

On Mon, 6 Dec 2021, Paolo Abeni wrote:

> The first patch was already shared as RFC, this iteration
> addresses a couple of bugs there.
>
> The second patch removes a bunch of conditionals and atomic
> operations in the fast path, but the performance impact is
> actually below noise level. Still I think it's worthy, as the
> unneeded atomic operations are confusing.
>
> Paolo Abeni (2):
>  mptcp: cleanup MPJ subflow list handling
>  mptcp: avoid atomic bit manipulation when possible
>
> net/mptcp/pm_netlink.c |   3 -
> net/mptcp/protocol.c   | 149 ++++++++++++++++++-----------------------
> net/mptcp/protocol.h   |  31 ++++-----
> net/mptcp/sockopt.c    |  24 ++-----
> net/mptcp/subflow.c    |   9 ++-
> 5 files changed, 89 insertions(+), 127 deletions(-)

Looks good to me:

Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>

Matthieu, note that this patch set depends on the "mptcp: improve subflow 
creation on errors" patches.

--
Mat Martineau
Intel