[v1] mptcp: improve subflow creation on errors

[PATCH mptcp-next 0/3] mptcp: improve subflow creation on errors

Paolo Abeni posted 3 patches 2 years, 5 months ago

Diff against v2 v2 v4 v5 v6
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1637684792.git.pabeni@redhat.com

Maintainers: Mat Martineau <mathew.j.martineau@linux.intel.com>, Shuah Khan <shuah@kernel.org>, Matthieu Baerts <matthieu.baerts@tessares.net>, "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>

There is a newer version of this series

net/mptcp/options.c                           | 63 ++++++++++++-------
net/mptcp/protocol.h                          |  1 +
net/mptcp/subflow.c                           | 12 +++-
.../testing/selftests/net/mptcp/mptcp_join.sh | 10 +++
4 files changed, 61 insertions(+), 25 deletions(-)

Expand all Fold all

[PATCH mptcp-next 0/3] mptcp: improve subflow creation on errors

Posted by Paolo Abeni 2 years, 5 months ago

Currently when a subflow connection fails - either the TCP
connection is reset by the peer, or the MPJ handshake never
completes - the in kernel PM don't perform any further action.
Notably no additional subflow creation is attempted.

This series is aimed at improving the in-kernel path manager
behavior in the above scenario: on failure we try to move
to the next subflow, if any.

The first patch is minor cleanup, the feature is implemented
by patch 2/3. The last patch adds a specific self-tests.

This should possibly address/close:
https://github.com/multipath-tcp/mptcp_net-next/issues/235
https://github.com/multipath-tcp/mptcp_net-next/issues/242

@Phil: could you please have a spin in your testbed and
see if this is enough to fit you?

Paolo Abeni (3):
  mptcp: clean-up MPJ option writing.
  mptcp: do not block subflows creation on errors
  selftests: mptcp: add tests for subflow creation failure

 net/mptcp/options.c                           | 63 ++++++++++++-------
 net/mptcp/protocol.h                          |  1 +
 net/mptcp/subflow.c                           | 12 +++-
 .../testing/selftests/net/mptcp/mptcp_join.sh | 10 +++
 4 files changed, 61 insertions(+), 25 deletions(-)

-- 
2.33.1

Re: [PATCH mptcp-next 0/3] mptcp: improve subflow creation on errors

Posted by Paolo Abeni 2 years, 5 months ago

On Tue, 2021-11-23 at 17:37 +0100, Paolo Abeni wrote:
> Currently when a subflow connection fails - either the TCP
> connection is reset by the peer, or the MPJ handshake never
> completes - the in kernel PM don't perform any further action.
> Notably no additional subflow creation is attempted.
> 
> This series is aimed at improving the in-kernel path manager
> behavior in the above scenario: on failure we try to move
> to the next subflow, if any.
> 
> The first patch is minor cleanup, the feature is implemented
> by patch 2/3. The last patch adds a specific self-tests.
> 
> This should possibly address/close:
> https://github.com/multipath-tcp/mptcp_net-next/issues/235
> https://github.com/multipath-tcp/mptcp_net-next/issues/242

Uhm... I actually missed a few points from issues/242. This does not
address the latter, yet.

Cheers,

Paolo