[v2] mptcp: fix MPJ 3rd ack retransmissions

[PATCH v2 mptcp-net 0/2] mptcp: fix MPJ 3rd ack retransmissions

Paolo Abeni posted 2 patches 2 years, 5 months ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1635885975.git.pabeni@redhat.com

Maintainers: "David S. Miller" <davem@davemloft.net>, Matthieu Baerts <matthieu.baerts@tessares.net>, Peter Krystad <peter.krystad@linux.intel.com>, Jakub Kicinski <kuba@kernel.org>, Florian Westphal <fw@strlen.de>, Mat Martineau <mathew.j.martineau@linux.intel.com>, Paolo Abeni <pabeni@redhat.com>

net/mptcp/options.c  | 32 ++++++++--------------------
net/mptcp/protocol.c | 50 ++++++++++++++++++++++++++++++++++++--------
net/mptcp/protocol.h | 17 ++++++++-------
3 files changed, 59 insertions(+), 40 deletions(-)

Expand all Fold all

[PATCH v2 mptcp-net 0/2] mptcp: fix MPJ 3rd ack retransmissions

Posted by Paolo Abeni 2 years, 5 months ago

The first patch is from Eric, thus is correct ;)
The 2nd one is much more doubtful, starting from the author ;)
The individual commit messages should be descriptive enough. With these
2 patches the related, pending pktdrill test:

https://github.com/multipath-tcp/packetdrill/pull/70

now complete successfully

v1 -> v2:
 - fix from delegated action invocation in patch 2/2 (Mat)

Eric Dumazet (1):
  mptcp: fix delack timer

Paolo Abeni (1):
  mptcp: use delegate action to schedule 3rd ack retrans

 net/mptcp/options.c  | 32 ++++++++--------------------
 net/mptcp/protocol.c | 50 ++++++++++++++++++++++++++++++++++++--------
 net/mptcp/protocol.h | 17 ++++++++-------
 3 files changed, 59 insertions(+), 40 deletions(-)

-- 
2.26.3

Re: [PATCH v2 mptcp-net 0/2] mptcp: fix MPJ 3rd ack retransmissions

Posted by Matthieu Baerts 2 years, 5 months ago

Hi Paolo, Mat,

On 02/11/2021 21:48, Paolo Abeni wrote:
> The first patch is from Eric, thus is correct ;)
> The 2nd one is much more doubtful, starting from the author ;)

:-P

> The individual commit messages should be descriptive enough. With these
> 2 patches the related, pending pktdrill test:
> 
> https://github.com/multipath-tcp/packetdrill/pull/70

There is one comment left on this PR. Should we merge it anyway?

> now complete successfully
> 
> v1 -> v2:
>  - fix from delegated action invocation in patch 2/2 (Mat)
> 
> Eric Dumazet (1):
>   mptcp: fix delack timer

@Paolo: I added your Acked-by on this one, no objection?

> Paolo Abeni (1):
>   mptcp: use delegate action to schedule 3rd ack retrans

Thank you for the patches and the reviews!

Now in our tree (fixes for -net) with Mat's RvB tag, without 2 typos
spotted by Mat and with 2 minor modifications to satisfy checkpatch
(spaces around '-' and max 100 chars per line):

- 0eeedc170fdf: mptcp: fix delack timer
- 232f203394ce: mptcp: use delegate action to schedule 3rd ack retrans
- Results: 6a2b7fa0be7c..c1d29ad013b4

Builds and tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20211104T141805
https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net