Hi Geliang, Mat,
On 29/10/2021 06:40, Geliang Tang wrote:
> v8:
> - Patches 1-6 are unchanged, only updated the selftests scripts.
> - The patch (Squash to "mptcp: infinite mapping receiving" for v7) is
> dropped too. Since this series only implemented MP_FAIL in one direction.
> The TODO items, "MP_FAIL echo" and "MP_FAIL retrans", will implement later
> as new patches.
(...)
Thank you for the patches and the reviews!
As discussed at the meeting yesterday, to help you moving forward, I
applied the first seven patches (without Mat's RvB tag for the moment).
What is then left to do if I'm not mistaken:
- drop more data from the receive queue c.f. discussions with Mat and
Christoph on the ML on v7
- Improvements around the tests for patch 8/8:
- Comment around the TC command
- Add 'tcp_flags 0x10/0xff'
- Comment around the parsing (example of what you are parsing)
- Break if jq returns 'null' or nothing.
- Sleep in the while loop for "tc show"
- Look for "pedit" counter ("packets" - "overlimits")
- Not compare the output file if it is normal they are different
- Remove/Reduce data sent by the host not having the tc command (send
only in one direction)
- Insert the TC rules, then start the test, then look at counters
- Force checksum=1 for "fail_tests()"
And for later:
- "MP_FAIL echo"
- "MP_FAIL retrans"
Did I miss anything?
The first patches are now in our tree (features for net-next):
- 19ca240f0cdf: mptcp: don't send RST for single subflow
- 89de2a435c1e: mptcp: add the fallback check
- df3d448153f1: mptcp: track and update contiguous data status
- 44b73ea648cc: mptcp: infinite mapping sending
- e35a1a951132: mptcp: infinite mapping receiving
- 9feb4bc20bf6: mptcp: add mib for infinite map sending
- ac67c5b1d612: selftests: mptcp: add infinite map mibs check
- Results: c1d29ad013b4..0fad1b3cf9ef
Builds and tests are now in progress:
https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20211105T130530
https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/216
Because there are still stuff to implement, this ticket has not been closed.
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net