[v1] mptcp: just another xmit path refactor

[PATCH mptcp-next 0/4] mptcp: just another xmit path refactor

Paolo Abeni posted 4 patches 4 years ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/dcaratti/mptcp_net-next tags/patchew/cover.1630591985.git.pabeni@redhat.com

Maintainers: David Ahern <dsahern@kernel.org>, Jonathan Corbet <corbet@lwn.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Matthieu Baerts <matthieu.baerts@tessares.net>, Mat Martineau <mathew.j.martineau@linux.intel.com>, "David S. Miller" <davem@davemloft.net>, Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>

There is a newer version of this series

Documentation/networking/ip-sysctl.rst |   8 --
include/net/sock.h                     |  19 ----
include/net/tcp.h                      |   4 +-
net/ipv4/af_inet.c                     |   4 -
net/ipv4/sysctl_net_ipv4.c             |  12 --
net/ipv4/tcp.c                         | 147 +++++++++----------------
net/ipv4/tcp_ipv4.c                    |   6 -
net/ipv6/tcp_ipv6.c                    |   6 -
net/mptcp/protocol.c                   | 131 +++++++++++++---------
9 files changed, 131 insertions(+), 206 deletions(-)

Expand all Fold all

[PATCH mptcp-next 0/4] mptcp: just another xmit path refactor

Posted by Paolo Abeni 4 years ago

Eric want to revert the tcp_tx_skb_cache. MPTCP relies on it
for skb allocation. Before the revert we need to refactor our
xmit path.

Patch 1 exposes some needed helpers (endorsed by Eric)
Patch 2 contains the nasty new code
Patch 3 revert some core TCP changes not needed anymore
and patch 4 is Eric's revert.

This is only lightly tested, and I already got a slab out-of-bound,
even if I could not reproduce it easily. Sharing early to give to
hopefully give more testing in our CI.

Eric Dumazet (1):
  tcp: remove sk_{tr}x_skb_cache

Paolo Abeni (3):
  tcp: expose the tcp_mark_push() and skb_entail() helpers
  mptcp: stop relaying on tcp_tx_skb_cache.
  Partially revert "tcp: factor out tcp_build_frag()"

 Documentation/networking/ip-sysctl.rst |   8 --
 include/net/sock.h                     |  19 ----
 include/net/tcp.h                      |   4 +-
 net/ipv4/af_inet.c                     |   4 -
 net/ipv4/sysctl_net_ipv4.c             |  12 --
 net/ipv4/tcp.c                         | 147 +++++++++----------------
 net/ipv4/tcp_ipv4.c                    |   6 -
 net/ipv6/tcp_ipv6.c                    |   6 -
 net/mptcp/protocol.c                   | 131 +++++++++++++---------
 9 files changed, 131 insertions(+), 206 deletions(-)

-- 
2.26.3