[PATCH iproute2] mptcp: unbreak JSON endpoint list

Davide Caratti posted 1 patch 3 weeks ago
Failed in applying to current master (apply log)
ip/ipmptcp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH iproute2] mptcp: unbreak JSON endpoint list

Posted by Davide Caratti 3 weeks ago
the following command:

 # ip -j mptcp endpoint show

prints a JSON array that misses the terminating bracket. Fix this calling
delete_json_obj() to balance the call to new_json_obj().

Fixes: 7e0767cd862b ("add support for mptcp netlink interface")
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
---
 ip/ipmptcp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ip/ipmptcp.c b/ip/ipmptcp.c
index bc12418bd39c..25d7d6784f89 100644
--- a/ip/ipmptcp.c
+++ b/ip/ipmptcp.c
@@ -262,7 +262,7 @@ static int mptcp_addr_dump(void)
 		return -2;
 	}
 
-	close_json_object();
+	delete_json_obj();
 	fflush(stdout);
 	return 0;
 }
-- 
2.31.1


Re: [PATCH iproute2] mptcp: unbreak JSON endpoint list

Posted by Andrea Claudi 3 weeks ago
On Thu, Sep 30, 2021 at 05:19:25PM +0200, Davide Caratti wrote:
> the following command:
> 
>  # ip -j mptcp endpoint show
> 
> prints a JSON array that misses the terminating bracket. Fix this calling
> delete_json_obj() to balance the call to new_json_obj().
> 
> Fixes: 7e0767cd862b ("add support for mptcp netlink interface")
> Signed-off-by: Davide Caratti <dcaratti@redhat.com>
> ---

LGTM.
Acked-by: Andrea Claudi <aclaudi@redhat.com>