selftests: mptcp: fix proto type in link_failure tests

[PATCH mptcp-next] selftests: mptcp: fix proto type in link_failure tests

Geliang Tang posted 1 patch 2 years, 6 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/73206a1932f3f6baab8cfe5bf210fb6fe4cc06cc.1634809754.git.geliang.tang@suse.com

Maintainers: Matthieu Baerts <matthieu.baerts@tessares.net>, "David S. Miller" <davem@davemloft.net>, Shuah Khan <shuah@kernel.org>, Mat Martineau <mathew.j.martineau@linux.intel.com>, Paolo Abeni <pabeni@redhat.com>, Geliang Tang <geliangtang@gmail.com>, Jakub Kicinski <kuba@kernel.org>

tools/testing/selftests/net/mptcp/mptcp_join.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH mptcp-next] selftests: mptcp: fix proto type in link_failure tests

Posted by Geliang Tang 2 years, 6 months ago

In listener_ns, we should pass srv_proto argument to mptcp_connect command,
not cl_proto.

Fixes: 7d1e6f1639044 ("selftests: mptcp: add testcase for active-back")
Signed-off-by: Geliang Tang <geliang.tang@suse.com>
---
 tools/testing/selftests/net/mptcp/mptcp_join.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh
index b3b351b868f9..129c859c6e3e 100755
--- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
+++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh
@@ -297,7 +297,7 @@ do_transfer()
 	if [ "$test_link_fail" -eq 2 ];then
 		timeout ${timeout_test} \
 			ip netns exec ${listener_ns} \
-				$mptcp_connect -t ${timeout_poll} -l -p $port -s ${cl_proto} \
+				$mptcp_connect -t ${timeout_poll} -l -p $port -s ${srv_proto} \
 					${local_addr} < "$sinfail" > "$sout" &
 	else
 		timeout ${timeout_test} \
-- 
2.26.2

Re: [PATCH mptcp-next] selftests: mptcp: fix proto type in link_failure tests

Posted by Matthieu Baerts 2 years, 6 months ago

Hi Geliang,

On 21/10/2021 11:51, Geliang Tang wrote:
> In listener_ns, we should pass srv_proto argument to mptcp_connect command,
> not cl_proto.
> 
> Fixes: 7d1e6f1639044 ("selftests: mptcp: add testcase for active-back")
> Signed-off-by: Geliang Tang <geliang.tang@suse.com>

Good catch!

Now in our tree (fix for -net) with my RvB tag:

- 17e467e6b4e3: selftests: mptcp: fix proto type in link_failure tests
- Results: 27b3739429a3..258d7013ee60

Builds and tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20211021T100936
https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export/20211021T100936

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net