[PATCH mptcp-next v2] Squash to "selftests: mptcp: add MP_FAIL reset testcase" - cleanups

Geliang Tang posted 1 patch 1 year, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/5f8677f1bf662a25beea0504c7981ab2e4c5531e.1651724227.git.geliang.tang@suse.com
Maintainers: Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Matthieu Baerts <matthieu.baerts@tessares.net>, Shuah Khan <shuah@kernel.org>, Mat Martineau <mathew.j.martineau@linux.intel.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>
tools/testing/selftests/net/mptcp/mptcp_join.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH mptcp-next v2] Squash to "selftests: mptcp: add MP_FAIL reset testcase" - cleanups
Posted by Geliang Tang 1 year, 11 months ago
Drop '+'s passed to chk_csum_nr, with Paolo's fix [1] for act_pedit, no
extra checksum failures now, no need to add '+'s anymore.

[1]
net/sched: act_pedit: really ensure the skb is writable

Signed-off-by: Geliang Tang <geliang.tang@suse.com>
---
v2:
 - keep test file sizes unchanged.
---
 tools/testing/selftests/net/mptcp/mptcp_join.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh
index a5e90532eaea..1a41f9ba00c6 100755
--- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
+++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh
@@ -2740,7 +2740,7 @@ fail_tests()
 		pm_nl_set_limits $ns2 0 1
 		pm_nl_add_endpoint $ns2 10.0.2.2 dev ns2eth2 flags subflow
 		run_tests $ns1 $ns2 10.0.1.1 1024
-		chk_join_nr 1 1 1 +1 +0 1 1 0 "$(pedit_action_pkts)"
+		chk_join_nr 1 1 1 1 0 1 1 0 "$(pedit_action_pkts)"
 	fi
 }
 
-- 
2.34.1


Re: [PATCH mptcp-next v2] Squash to "selftests: mptcp: add MP_FAIL reset testcase" - cleanups
Posted by Matthieu Baerts 1 year, 11 months ago
Hi Geliang, Mat,

On 05/05/2022 06:19, Geliang Tang wrote:
> Drop '+'s passed to chk_csum_nr, with Paolo's fix [1] for act_pedit, no
> extra checksum failures now, no need to add '+'s anymore.
> 
> [1]
> net/sched: act_pedit: really ensure the skb is writable

Thank you for the patch and the review!

- f0356d33bafd: "squashed" in "selftests: mptcp: add MP_FAIL reset testcase"
- Results: 9a52d7243fda..9a06ad1b6cf2 (export)

Builds and tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20220506T192929
https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net