[PATCH mptcp-next] Squash to "selftests: mptcp: add chk_subflows_total helper"

Geliang Tang posted 1 patch 6 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/4bcf528d5ec4163c0ed64bc62566d8574e7f09d1.1700277365.git.geliang.tang@suse.com
Maintainers: Matthieu Baerts <matttbe@kernel.org>, Mat Martineau <martineau@kernel.org>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>
tools/testing/selftests/net/mptcp/mptcp_join.sh | 1 +
1 file changed, 1 insertion(+)
[PATCH mptcp-next] Squash to "selftests: mptcp: add chk_subflows_total helper"
Posted by Geliang Tang 6 months ago
Add missing "local dump_stats".

Otherwise, no place to set 0 to dump_stats, if a test fails. Then
unexpected dump infos will be showed in all the subsequent outputs
of chk_subflows_total().

Signed-off-by: Geliang Tang <geliang.tang@suse.com>
---
 tools/testing/selftests/net/mptcp/mptcp_join.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh
index 1606474232f6..8362ea454af3 100755
--- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
+++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh
@@ -1841,6 +1841,7 @@ chk_subflows_total()
 	local cnt1
 	local cnt2
 	local info="subflows_total"
+	local dump_stats
 
 	# if subflows_total counter is supported, use it:
 	if [ -n "$(ss -N $ns1 -inmHM | mptcp_lib_get_info_value $info $info)" ]; then
-- 
2.35.3
Re: [PATCH mptcp-next] Squash to "selftests: mptcp: add chk_subflows_total helper"
Posted by Matthieu Baerts 5 months, 2 weeks ago
Hi Geliang,

On 18/11/2023 04:16, Geliang Tang wrote:
> Add missing "local dump_stats".
> 
> Otherwise, no place to set 0 to dump_stats, if a test fails. Then
> unexpected dump infos will be showed in all the subsequent outputs
> of chk_subflows_total().

Good catch!

Thank you for the patch, now in our tree:

New patches for t/upstream:
- 45047d0dc10f: "squashed" in "selftests: mptcp: add chk_subflows_total
helper"
- Results: d4787f01696d..1ee636354037 (export)

Tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20231127T175348

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.