[v1] Squash to "selftests: bpf: add bpf_first test"

[PATCH mptcp-next] Squash to "selftests: bpf: add bpf_first test"

Geliang Tang posted 1 patch 1 year, 11 months ago

Diff against v1
Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/3efc49e473d2fbb03c9577aea5959b35d29d2c9e.1651625191.git.geliang.tang@suse.com

Maintainers: Daniel Borkmann <daniel@iogearbox.net>, Martin KaFai Lau <kafai@fb.com>, John Fastabend <john.fastabend@gmail.com>, Song Liu <songliubraving@fb.com>, Matthieu Baerts <matthieu.baerts@tessares.net>, Mat Martineau <mathew.j.martineau@linux.intel.com>, Andrii Nakryiko <andrii@kernel.org>, Alexei Starovoitov <ast@kernel.org>, Shuah Khan <shuah@kernel.org>, Yonghong Song <yhs@fb.com>, KP Singh <kpsingh@kernel.org>

There is a newer version of this series

tools/testing/selftests/bpf/prog_tests/mptcp.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH mptcp-next] Squash to "selftests: bpf: add bpf_first test"

Posted by Geliang Tang 1 year, 11 months ago

Set scheduler to default after test.

Signed-off-by: Geliang Tang <geliang.tang@suse.com>
---
 tools/testing/selftests/bpf/prog_tests/mptcp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/bpf/prog_tests/mptcp.c b/tools/testing/selftests/bpf/prog_tests/mptcp.c
index 925858d63a9c..3106e013b9ca 100644
--- a/tools/testing/selftests/bpf/prog_tests/mptcp.c
+++ b/tools/testing/selftests/bpf/prog_tests/mptcp.c
@@ -371,6 +371,7 @@ static void test_first(void)
 
 	close(client_fd);
 	close(server_fd);
+	system("sysctl -qw net.mptcp.scheduler=default");
 	bpf_link__destroy(link);
 	mptcp_bpf_first__destroy(first_skel);
 }
-- 
2.34.1

Re: [PATCH mptcp-next] Squash to "selftests: bpf: add bpf_first test"

Posted by Matthieu Baerts 1 year, 11 months ago

Hi Geliang, Mat,

On 04/05/2022 02:47, Geliang Tang wrote:
> Set scheduler to default after test.

Thank you for the patch and the review!

Now in our tree:

New patches for t/upstream:
- 56aa85d15070: "squashed" in "selftests: bpf: add bpf_first test"
- Results: 9cac72edfb62..ba73bf84ee7f (export)

Builds and tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20220504T070238
https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net

Re: [PATCH mptcp-next] Squash to "selftests: bpf: add bpf_first test"

Posted by Mat Martineau 1 year, 11 months ago

On Wed, 4 May 2022, Geliang Tang wrote:

> Set scheduler to default after test.

Looks good to squash, thanks Geliang.

- Mat

>
> Signed-off-by: Geliang Tang <geliang.tang@suse.com>
> ---
> tools/testing/selftests/bpf/prog_tests/mptcp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/mptcp.c b/tools/testing/selftests/bpf/prog_tests/mptcp.c
> index 925858d63a9c..3106e013b9ca 100644
> --- a/tools/testing/selftests/bpf/prog_tests/mptcp.c
> +++ b/tools/testing/selftests/bpf/prog_tests/mptcp.c
> @@ -371,6 +371,7 @@ static void test_first(void)
>
> 	close(client_fd);
> 	close(server_fd);
> +	system("sysctl -qw net.mptcp.scheduler=default");
> 	bpf_link__destroy(link);
> 	mptcp_bpf_first__destroy(first_skel);
> }
> -- 
> 2.34.1
>
>
>

--
Mat Martineau
Intel