[PATCH mptcp-next] Squash to "mptcp: implement .read_sock"

Geliang Tang posted 1 patch 1 week, 2 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/3bb22c78b078988462e13e72aa6fd9a29b07a8a0.1763437914.git.tanggeliang@kylinos.cn
There is a newer version of this series
net/mptcp/protocol.c | 2 ++
1 file changed, 2 insertions(+)
[PATCH mptcp-next] Squash to "mptcp: implement .read_sock"
Posted by Geliang Tang 1 week, 2 days ago
From: Geliang Tang <tanggeliang@kylinos.cn>

Squash to "[v13,2/8] mptcp: implement .read_sock".

Add sock_owned_by_me().

Based-on: <cover.1761198660.git.geliang@kernel.org>

Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
---
 net/mptcp/protocol.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
index c64494b15a40..873c1a93b777 100644
--- a/net/mptcp/protocol.c
+++ b/net/mptcp/protocol.c
@@ -4304,6 +4304,8 @@ static int mptcp_read_sock(struct sock *sk, read_descriptor_t *desc,
 	int copied = 0;
 	u32 offset;
 
+	sock_owned_by_me(sk);
+
 	if (sk->sk_state == TCP_LISTEN)
 		return -ENOTCONN;
 	while ((skb = mptcp_recv_skb(sk, &offset)) != NULL) {
-- 
2.51.0
Re: [PATCH mptcp-next] Squash to "mptcp: implement .read_sock"
Posted by MPTCP CI 1 week, 2 days ago
Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal (except selftest_mptcp_join): Unstable: 2 failed test(s): packetdrill_dss selftest_simult_flows 🔴
- KVM Validation: normal (only selftest_mptcp_join): Success! ✅
- KVM Validation: debug (except selftest_mptcp_join): Unstable: 1 failed test(s): packetdrill_dss 🔴
- KVM Validation: debug (only selftest_mptcp_join): Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/19453838924

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/19b94f025bc9
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=1024634


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)