[v1] Squash to "selftests: bpf: add MPTCP test base"

[PATCH mptcp-next] Squash to "selftests: bpf: add MPTCP test base"

Geliang Tang posted 1 patch 3 years, 4 months ago

Diff against v1 v1
Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/38168fb95c78454db24726d2bd45f2d65d977fda.1651022882.git.geliang.tang@suse.com

Maintainers: Song Liu <songliubraving@fb.com>, Shuah Khan <shuah@kernel.org>, Martin KaFai Lau <kafai@fb.com>, Yonghong Song <yhs@fb.com>, John Fastabend <john.fastabend@gmail.com>, KP Singh <kpsingh@kernel.org>, Andrii Nakryiko <andrii@kernel.org>, Alexei Starovoitov <ast@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>

There is a newer version of this series

tools/testing/selftests/bpf/config | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[PATCH mptcp-next] Squash to "selftests: bpf: add MPTCP test base"

Posted by Geliang Tang 3 years, 4 months ago

Add CONFIG_IKCONFIG and CONFIG_IKCONFIG_PROC as Mat suggested.

Signed-off-by: Geliang Tang <geliang.tang@suse.com>
---
 tools/testing/selftests/bpf/config | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/bpf/config b/tools/testing/selftests/bpf/config
index fe0d3ad6ecd8..f3391d0abe58 100644
--- a/tools/testing/selftests/bpf/config
+++ b/tools/testing/selftests/bpf/config
@@ -54,3 +54,5 @@ CONFIG_NF_DEFRAG_IPV6=y
 CONFIG_NF_CONNTRACK=y
 CONFIG_USERFAULTFD=y
 CONFIG_MPTCP=y
+CONFIG_IKCONFIG=y
+CONFIG_IKCONFIG_PROC=y
-- 
2.34.1

Re: [PATCH mptcp-next] Squash to "selftests: bpf: add MPTCP test base"

Posted by Matthieu Baerts 3 years, 4 months ago

Hi Geliang,

Thank you for the patch!

On 27/04/2022 03:28, Geliang Tang wrote:
> Add CONFIG_IKCONFIG and CONFIG_IKCONFIG_PROC as Mat suggested.

Mat's second reply on...

  Squash to "selftests: bpf: test bpf_skc_to_mptcp_sock"

...patch confuses me but I think he meant: we need this patch as it is
and that's why it is marked as Queued on Patchwork. But for this fix
here, it is probably best to have a dedicated patch and not a Squash-to
one because these two config should have been added before as they are
needed by other BPF selftests.

Did I misunderstand?

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net

Re: [PATCH mptcp-next] Squash to "selftests: bpf: add MPTCP test base"

Posted by Mat Martineau 3 years, 4 months ago

On Wed, 27 Apr 2022, Matthieu Baerts wrote:

> Hi Geliang,
>
> Thank you for the patch!
>
> On 27/04/2022 03:28, Geliang Tang wrote:
>> Add CONFIG_IKCONFIG and CONFIG_IKCONFIG_PROC as Mat suggested.
>
> Mat's second reply on...
>
>  Squash to "selftests: bpf: test bpf_skc_to_mptcp_sock"
>
> ...patch confuses me but I think he meant: we need this patch as it is
> and that's why it is marked as Queued on Patchwork. But for this fix
> here, it is probably best to have a dedicated patch and not a Squash-to
> one because these two config should have been added before as they are
> needed by other BPF selftests.
>
> Did I misunderstand?
>

You understood correctly, Mattheiu. If I send a v2 of the bpf-next patches 
today I will add the commit and also queue it in our patchwork.

--
Mat Martineau
Intel