[PATCH mptcp-net] selftests: mptcp: join: dump stats with right title

Matthieu Baerts (NGI0) posted 1 patch 1 week, 4 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/20260914-mptcp-sft-join-typo-ns-stat-v1-1-30d5a5802b57@kernel.org
tools/testing/selftests/net/mptcp/mptcp_join.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH mptcp-net] selftests: mptcp: join: dump stats with right title
Posted by Matthieu Baerts (NGI0) 1 week, 4 days ago
This fixes a typo when dumping stats to print the right netns.

Indeed, the client netns was hardcoded instead of taking the netns given
in argument. Fixing that to avoid confusions when debugging issues.

Fixes: 658e53141780 ("selftests: mptcp: join: dump stats from history")
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
 tools/testing/selftests/net/mptcp/mptcp_join.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh
index b16e24418e73..bec499047e06 100755
--- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
+++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh
@@ -1163,7 +1163,7 @@ _dump_stats()
 	local ns="${1}"
 	local side="${2}"
 
-	mptcp_lib_print_err "${side} ns stats (${ns2})"
+	mptcp_lib_print_err "${side} ns stats (${ns})"
 	mptcp_lib_pr_nstat "${ns}"
 	echo
 }

---
base-commit: 060af37701a3aca2c02cb5e874d740be6acbf1a2
change-id: 20260914-mptcp-sft-join-typo-ns-stat-4db20f0b7a48

Best regards,
--  
Matthieu Baerts (NGI0) <matttbe@kernel.org>
Re: [PATCH mptcp-net] selftests: mptcp: join: dump stats with right title
Posted by Geliang Tang 1 week, 4 days ago
Hi Matt,

On Mon, 2026-09-14 at 19:53 +0200, Matthieu Baerts (NGI0) wrote:
> This fixes a typo when dumping stats to print the right netns.
> 
> Indeed, the client netns was hardcoded instead of taking the netns
> given
> in argument. Fixing that to avoid confusions when debugging issues.
> 
> Fixes: 658e53141780 ("selftests: mptcp: join: dump stats from
> history")
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> ---
>  tools/testing/selftests/net/mptcp/mptcp_join.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh
> b/tools/testing/selftests/net/mptcp/mptcp_join.sh
> index b16e24418e73..bec499047e06 100755
> --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
> +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh
> @@ -1163,7 +1163,7 @@ _dump_stats()
>  	local ns="${1}"
>  	local side="${2}"
>  
> -	mptcp_lib_print_err "${side} ns stats (${ns2})"
> +	mptcp_lib_print_err "${side} ns stats (${ns})"

Good catch!

    Reviewed-by: Geliang Tang <geliang@kernel.org>

Thanks,
-Geliang

>  	mptcp_lib_pr_nstat "${ns}"
>  	echo
>  }
> 
> ---
> base-commit: 060af37701a3aca2c02cb5e874d740be6acbf1a2
> change-id: 20260914-mptcp-sft-join-typo-ns-stat-4db20f0b7a48
> 
> Best regards,
> --  
> Matthieu Baerts (NGI0) <matttbe@kernel.org>
> 
Re: [PATCH mptcp-net] selftests: mptcp: join: dump stats with right title
Posted by MPTCP CI 1 week, 4 days ago
Hi Matthieu,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal (except selftest_mptcp_join): Success! ✅
- KVM Validation: normal (only selftest_mptcp_join): Success! ✅
- KVM Validation: debug (except selftest_mptcp_join): Success! ✅
- KVM Validation: debug (only selftest_mptcp_join): Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Perf: Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/34878576649

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/88a039d1d133
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=1164806


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)