net/mptcp/protocol.h | 1 - net/mptcp/subflow.c | 19 +++++++++---------- net/mptcp/syncookies.c | 5 ++++- 3 files changed, 13 insertions(+), 12 deletions(-)
This is a follow-up of [1], but addressing even less problematic
entries.
The first patch saves request_bkup, the second one avoids a possible
(harmless) KMSAN warning, and the 3rd one is a cleanup for next.
Link: https://lore.kernel.org/20260815115205.197151-1-harshitvaru666@gmail.com
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
Matthieu Baerts (NGI0) (3):
mptcp: syncookies: remember the request backup flag
mptcp: subflow: no need to copy thmac during ulp_clone
[next] mptcp: remove thmac from subflow ctx
net/mptcp/protocol.h | 1 -
net/mptcp/subflow.c | 19 +++++++++----------
net/mptcp/syncookies.c | 5 ++++-
3 files changed, 13 insertions(+), 12 deletions(-)
---
base-commit: 61862bf50d532e8a538221643cd75d25a6f4f0f4
change-id: 20260816-mptcp-cook-reqb-6f35d027cd15
Best regards,
--
Matthieu Baerts (NGI0) <matttbe@kernel.org>
Hi Matthieu,
Thank you for your modifications, that's great!
Our CI did some validations and here is its report:
- KVM Validation: normal (except selftest_mptcp_join): Success! ✅
- KVM Validation: normal (only selftest_mptcp_join): Success! ✅
- KVM Validation: debug (except selftest_mptcp_join): Success! ✅
- KVM Validation: debug (only selftest_mptcp_join): Unstable: 1 failed test(s): selftest_mptcp_join ⚠️
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/32171215149
Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/4172949dd486
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=1148008
If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:
$ cd [kernel source code]
$ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
--pull always mptcp/mptcp-upstream-virtme-docker:latest \
auto-normal
For more details:
https://github.com/multipath-tcp/mptcp-upstream-virtme-docker
Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)
Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)
Hi Matt,
On Tue, 2026-08-18 at 19:20 +0000, MPTCP CI wrote:
> Hi Matthieu,
>
> Thank you for your modifications, that's great!
>
> Our CI did some validations and here is its report:
>
> - KVM Validation: normal (except selftest_mptcp_join): Success! ✅
> - KVM Validation: normal (only selftest_mptcp_join): Success! ✅
> - KVM Validation: debug (except selftest_mptcp_join): Success! ✅
> - KVM Validation: debug (only selftest_mptcp_join): Unstable: 1
> failed test(s): selftest_mptcp_join ⚠️
> - KVM Validation: btf-normal (only bpftest_all): Success! ✅
> - KVM Validation: btf-debug (only bpftest_all): Success! ✅
This series looks good to me!
Reviewed-by: Geliang Tang <geliang@kernel.org>
nit: You could squash patch 2 into patch 3 if you want, but totally up
to you.
Thanks,
-Geliang
> - Task:
> https://github.com/multipath-tcp/mptcp_net-next/actions/runs/32171215149
>
> Initiator: Patchew Applier
> Commits:
> https://github.com/multipath-tcp/mptcp_net-next/commits/4172949dd486
> Patchwork:
> https://patchwork.kernel.org/project/mptcp/list/?series=1148008
>
>
> If there are some issues, you can reproduce them using the same
> environment as
> the one used by the CI thanks to a docker image, e.g.:
>
> $ cd [kernel source code]
> $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm
> -it \
> --pull always mptcp/mptcp-upstream-virtme-docker:latest \
> auto-normal
>
> For more details:
>
> https://github.com/multipath-tcp/mptcp-upstream-virtme-docker
>
>
> Please note that despite all the efforts that have been already done
> to have a
> stable tests suite when executed on a public CI like here, it is
> possible some
> reported issues are not due to your modifications. Still, do not
> hesitate to
> help us improve that ;-)
>
> Cheers,
> MPTCP GH Action bot
> Bot operated by Matthieu Baerts (NGI0 Core)
Hi Geliang, On 21/08/2026 07:37, Geliang Tang wrote: > Hi Matt, > > On Tue, 2026-08-18 at 19:20 +0000, MPTCP CI wrote: >> Hi Matthieu, >> >> Thank you for your modifications, that's great! >> >> Our CI did some validations and here is its report: >> >> - KVM Validation: normal (except selftest_mptcp_join): Success! ✅ >> - KVM Validation: normal (only selftest_mptcp_join): Success! ✅ >> - KVM Validation: debug (except selftest_mptcp_join): Success! ✅ >> - KVM Validation: debug (only selftest_mptcp_join): Unstable: 1 >> failed test(s): selftest_mptcp_join ⚠️ >> - KVM Validation: btf-normal (only bpftest_all): Success! ✅ >> - KVM Validation: btf-debug (only bpftest_all): Success! ✅ > > This series looks good to me! Thank you for the review! New patches for t/upstream-net and t/upstream: - cba636a2dcab: mptcp: syncookies: remember the request backup flag - 413a21edd334: mptcp: subflow: no need to copy thmac during ulp_clone - Results: eeb8d1d44a74..6bb246941708 (export-net) - Results: 41733b9765ba..aa4bae9bfb46 (export) Tests are now in progress: - export-net: https://github.com/multipath-tcp/mptcp_net-next/commit/d9e7fa174e7b3c63fafb99573c8c7e1a8ce53b06/checks New patches for t/upstream: - 631307ac3350: mptcp: remove thmac from subflow ctx - Results: aa4bae9bfb46..2f5abecdd265 (export) Tests are now in progress: - export: https://github.com/multipath-tcp/mptcp_net-next/commit/c2aae803b2f7c409357b41bf3e0dbd7eda58a4ee/checks > nit: You could squash patch 2 into patch 3 if you want, but totally up > to you. I didn't: the 2nd patch is -net material, while the 3rd one is for -next. Cheers, Matt -- Sponsored by the NGI0 Core fund.
© 2016 - 2026 Red Hat, Inc.