[PATCH mptcp-next 0/3] selftests: mptcp: small pcap-related improvements

Matthieu Baerts (NGI0) posted 3 patches 3 months, 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/20260501-mptcp-sft-pcap-prefix-v1-0-27affca69415@kernel.org
tools/testing/selftests/net/mptcp/mptcp_connect.sh |  8 ++++----
tools/testing/selftests/net/mptcp/mptcp_join.sh    |  2 +-
tools/testing/selftests/net/mptcp/simult_flows.sh  | 11 ++++++++---
3 files changed, 13 insertions(+), 8 deletions(-)
[PATCH mptcp-next 0/3] selftests: mptcp: small pcap-related improvements
Posted by Matthieu Baerts (NGI0) 3 months, 2 weeks ago
- Patches 1-2: add test name in pcap files.

- Patch 3: drop payload from pcap by limiting the per packet size.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
Matthieu Baerts (NGI0) (3):
      selftests: mptcp: connect: test name in pcap file
      selftests: mptcp: simult_flow: test name in pcap file
      selftests: mptcp: pcap: drop most of the payload

 tools/testing/selftests/net/mptcp/mptcp_connect.sh |  8 ++++----
 tools/testing/selftests/net/mptcp/mptcp_join.sh    |  2 +-
 tools/testing/selftests/net/mptcp/simult_flows.sh  | 11 ++++++++---
 3 files changed, 13 insertions(+), 8 deletions(-)
---
base-commit: 7478b1b74fb5013908a4237d3f929f3db03fb74e
change-id: 20260501-mptcp-sft-pcap-prefix-b6b6250c50ce

Best regards,
--  
Matthieu Baerts (NGI0) <matttbe@kernel.org>
Re: [PATCH mptcp-next 0/3] selftests: mptcp: small pcap-related improvements
Posted by Mat Martineau 2 months, 4 weeks ago
On Fri, 1 May 2026, Matthieu Baerts (NGI0) wrote:

> - Patches 1-2: add test name in pcap files.
>
> - Patch 3: drop payload from pcap by limiting the per packet size.
>
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> ---
> Matthieu Baerts (NGI0) (3):
>      selftests: mptcp: connect: test name in pcap file
>      selftests: mptcp: simult_flow: test name in pcap file
>      selftests: mptcp: pcap: drop most of the payload
>
> tools/testing/selftests/net/mptcp/mptcp_connect.sh |  8 ++++----
> tools/testing/selftests/net/mptcp/mptcp_join.sh    |  2 +-
> tools/testing/selftests/net/mptcp/simult_flows.sh  | 11 ++++++++---
> 3 files changed, 13 insertions(+), 8 deletions(-)
> ---
> base-commit: 7478b1b74fb5013908a4237d3f929f3db03fb74e
> change-id: 20260501-mptcp-sft-pcap-prefix-b6b6250c50ce

Series LGTM, thanks Matthieu

Reviewed-by: Mat Martineau <martineau@kernel.org>
Re: [PATCH mptcp-next 0/3] selftests: mptcp: small pcap-related improvements
Posted by Matthieu Baerts 2 months, 4 weeks ago
Hi Mat,

On 21/05/2026 10:56, Mat Martineau wrote:
> On Fri, 1 May 2026, Matthieu Baerts (NGI0) wrote:
> 
>> - Patches 1-2: add test name in pcap files.
>>
>> - Patch 3: drop payload from pcap by limiting the per packet size.
>
> Series LGTM, thanks Matthieu

Thank you for the review! Now in our tree:

New patches for t/upstream:
- f61bf3c2aaee: selftests: mptcp: connect: test name in pcap file
- 1c879ef9314d: selftests: mptcp: simult_flow: test name in pcap file
- 6fce373a33a2: selftests: mptcp: pcap: drop most of the payload
- Results: 1fa2f477d53d..676e99102442 (export)

Tests are now in progress:

- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/02d6f438cb554cd30299e2857b36e4d3ff9b1735/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.
Re: [PATCH mptcp-next 0/3] selftests: mptcp: small pcap-related improvements
Posted by MPTCP CI 3 months, 2 weeks ago
Hi Matthieu,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal (except selftest_mptcp_join): Success! ✅
- KVM Validation: normal (only selftest_mptcp_join): Success! ✅
- KVM Validation: debug (except selftest_mptcp_join): Unstable: 2 failed test(s): packetdrill_mp_capable packetdrill_syscalls ⚠️ 
- KVM Validation: debug (only selftest_mptcp_join): Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/25226030943

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/4d003db9c654
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=1088610


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)