[v2] mptcp: pm: in-kernel: fix issue 606

[PATCH mptcp-net v2 0/2] mptcp: pm: in-kernel: fix issue 606

Posted by Matthieu Baerts (NGI0) 4 days, 8 hours ago

The first patch fixes it, the other one clarify the code. I think both
can go to -net.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
Changes in v2:
- Patch 1: avoid setting the bit twice + comment (Mat)
- Link to v1: https://patch.msgid.link/20251215-issue-606-mark-subflow-endp-avail-v1-0-2f1b36da8993@kernel.org

---
Matthieu Baerts (NGI0) (2):
      mptcp: pm: in-kernel: always set as unavail when removing addr
      mptcp: pm: in-kernel: clarify mptcp_pm_remove_anno_addr()

 net/mptcp/pm_kernel.c | 29 ++++++++++++-----------------
 1 file changed, 12 insertions(+), 17 deletions(-)
---
base-commit: 1f27d14ad2803370bd6232df91f864f12f77ead7
change-id: 20251212-issue-606-mark-subflow-endp-avail-ccc3322ff800

Best regards,
-- 
Matthieu Baerts (NGI0) <matttbe@kernel.org>

Re: [PATCH mptcp-net v2 0/2] mptcp: pm: in-kernel: fix issue 606

Posted by Mat Martineau 3 days, 1 hour ago

On Mon, 2 Feb 2026, Matthieu Baerts (NGI0) wrote:

> The first patch fixes it, the other one clarify the code. I think both
> can go to -net.
>
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> ---
> Changes in v2:
> - Patch 1: avoid setting the bit twice + comment (Mat)
> - Link to v1: https://patch.msgid.link/20251215-issue-606-mark-subflow-endp-avail-v1-0-2f1b36da8993@kernel.org

Thanks for the v2 Matthieu, LGTM:

Reviewed-by: Mat Martineau <martineau@kernel.org>

>
> ---
> Matthieu Baerts (NGI0) (2):
>      mptcp: pm: in-kernel: always set as unavail when removing addr
>      mptcp: pm: in-kernel: clarify mptcp_pm_remove_anno_addr()
>
> net/mptcp/pm_kernel.c | 29 ++++++++++++-----------------
> 1 file changed, 12 insertions(+), 17 deletions(-)
> ---
> base-commit: 1f27d14ad2803370bd6232df91f864f12f77ead7
> change-id: 20251212-issue-606-mark-subflow-endp-avail-ccc3322ff800
>
> Best regards,
> -- 
> Matthieu Baerts (NGI0) <matttbe@kernel.org>
>
>
>

Re: [PATCH mptcp-net v2 0/2] mptcp: pm: in-kernel: fix issue 606

Posted by Matthieu Baerts 2 days, 17 hours ago

Hi Mat,

On 04/02/2026 02:45, Mat Martineau wrote:
> On Mon, 2 Feb 2026, Matthieu Baerts (NGI0) wrote:
> 
>> The first patch fixes it, the other one clarify the code. I think both
>> can go to -net.
>>
>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
>> ---
>> Changes in v2:
>> - Patch 1: avoid setting the bit twice + comment (Mat)
>> - Link to v1: https://patch.msgid.link/20251215-issue-606-mark-
>> subflow-endp-avail-v1-0-2f1b36da8993@kernel.org
> 
> Thanks for the v2 Matthieu, LGTM:
> 
> Reviewed-by: Mat Martineau <martineau@kernel.org>

Thank you for the review!

Now in our tree:

New patches for t/upstream-net and t/upstream:
- cee9083edbf5: mptcp: pm: in-kernel: always set as unavail when
removing addr
- 86e2def61c79: mptcp: pm: in-kernel: clarify mptcp_pm_remove_anno_addr()
- Results: 67f92bf018dc..706883b2eaf9 (export-net)
- Results: e5a8401c4fcf..7fc1dc7ad76c (export)

Tests are now in progress:

- export-net:
https://github.com/multipath-tcp/mptcp_net-next/commit/fd385d67a3ac50c56251c8ef5727bfc9d4f75433/checks
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/d9da9924531f74d3d66b4f4a07daacb006917111/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.