Fix kdoc warning reported by NIPA:

  Warning: net/mptcp/protocol.c:4424 No description found for return value of 'mptcp_splice_read'

Validated using:

  ./scripts/kernel-doc -Wall -none net/mptcp/protocol.c

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
 net/mptcp/protocol.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
index 1b87b3b0d089..c88882062c40 100644
--- a/net/mptcp/protocol.c
+++ b/net/mptcp/protocol.c
@@ -4425,6 +4425,9 @@ static int __mptcp_splice_read(struct sock *sk, struct tcp_splice_state *tss)
  * Description:
  *    Will read pages from given socket and fill them into a pipe.
  *
+ * Return:
+ *    Amount of bytes that have been spliced.
+ *
  **/
 static ssize_t mptcp_splice_read(struct socket *sock, loff_t *ppos,
 				 struct pipe_inode_info *pipe, size_t len,

---
base-commit: 9eafdb3251fecf25d365143d1a7da2dca70f181f
change-id: 20260130-mptcp-splice-return-kdoc-6d92ca94c461

Best regards,
-- 
Matthieu Baerts (NGI0) <matttbe@kernel.org>

Hi Matthieu,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal (except selftest_mptcp_join): Success! ✅
- KVM Validation: normal (only selftest_mptcp_join): Success! ✅
- KVM Validation: debug (except selftest_mptcp_join): Unstable: 1 failed test(s): packetdrill_dss 🔴
- KVM Validation: debug (only selftest_mptcp_join): Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Unstable: 1 failed test(s): bpftest_test_progs_mptcp 🔴
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/21508373182

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/30d7bf78ee28
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=1048859


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)

Hi Matt,

Thanks for this fix.

On Fri, 2026-01-30 at 08:37 +0100, Matthieu Baerts (NGI0) wrote:
> Fix kdoc warning reported by NIPA:
> 
>   Warning: net/mptcp/protocol.c:4424 No description found for return
> value of 'mptcp_splice_read'
> 
> Validated using:
> 
>   ./scripts/kernel-doc -Wall -none net/mptcp/protocol.c
> 
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

Looks good to me.

Reviewed-by: Geliang Tang <geliang@kernel.org>

-Geliang

> ---
>  net/mptcp/protocol.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
> index 1b87b3b0d089..c88882062c40 100644
> --- a/net/mptcp/protocol.c
> +++ b/net/mptcp/protocol.c
> @@ -4425,6 +4425,9 @@ static int __mptcp_splice_read(struct sock *sk,
> struct tcp_splice_state *tss)
>   * Description:
>   *    Will read pages from given socket and fill them into a pipe.
>   *
> + * Return:
> + *    Amount of bytes that have been spliced.
> + *
>   **/
>  static ssize_t mptcp_splice_read(struct socket *sock, loff_t *ppos,
>  				 struct pipe_inode_info *pipe,
> size_t len,
> 
> ---
> base-commit: 9eafdb3251fecf25d365143d1a7da2dca70f181f
> change-id: 20260130-mptcp-splice-return-kdoc-6d92ca94c461
> 
> Best regards,

Hi Geliang,

On 30/01/2026 09:23, Geliang Tang wrote:
> Hi Matt,
> 
> Thanks for this fix.
> 
> On Fri, 2026-01-30 at 08:37 +0100, Matthieu Baerts (NGI0) wrote:
>> Fix kdoc warning reported by NIPA:
>>
>>   Warning: net/mptcp/protocol.c:4424 No description found for return
>> value of 'mptcp_splice_read'
>>
>> Validated using:
>>
>>   ./scripts/kernel-doc -Wall -none net/mptcp/protocol.c
>>
>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> 
> Looks good to me.
> 
> Reviewed-by: Geliang Tang <geliang@kernel.org>

Thank you for the quick review!

Now in our tree:

- 254184df9e45: "squashed" in "mptcp: implement .splice_read"

No tests just for that.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.