[PATCH mptcp-next] DO-NOT-MERGE: mark some simult flows tests as flaky

Matthieu Baerts (NGI0) posted 1 patch 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/20260130-mptcp-issue-607-tmp-fix-v1-1-c7fbfa0c2915@kernel.org
tools/testing/selftests/net/mptcp/simult_flows.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH mptcp-next] DO-NOT-MERGE: mark some simult flows tests as flaky
Posted by Matthieu Baerts (NGI0) 1 week ago
This is just to reduce the noise while we are working a solution for
issue 607:

  selftests: simult_flows: "unbalanced bwidth with opposed, unbalanced
  delay" (+ "reverse direction") are unstable

Suggested by Paolo: commit "mptcp: better mptcp-level RTT estimator" is
probably correct, but likely it uncovers some underlying issues (in ack
generation?).

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
To be placed just after/before the commit causing the instabilities.
---
 tools/testing/selftests/net/mptcp/simult_flows.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/mptcp/simult_flows.sh b/tools/testing/selftests/net/mptcp/simult_flows.sh
index 806aaa7d2d61..a9c9927d6cbc 100755
--- a/tools/testing/selftests/net/mptcp/simult_flows.sh
+++ b/tools/testing/selftests/net/mptcp/simult_flows.sh
@@ -304,7 +304,7 @@ run_test 10 10 1 25 "balanced bwidth with unbalanced delay"
 # we still need some additional infrastructure to pass the following test-cases
 MPTCP_LIB_SUBTEST_FLAKY=1 run_test 10 3 0 0 "unbalanced bwidth"
 run_test 10 3 1 25 "unbalanced bwidth with unbalanced delay"
-run_test 10 3 25 1 "unbalanced bwidth with opposed, unbalanced delay"
+MPTCP_LIB_SUBTEST_FLAKY=1 run_test 10 3 25 1 "unbalanced bwidth with opposed, unbalanced delay"
 
 mptcp_lib_result_print_all_tap
 exit $ret

---
base-commit: 50e7f60d4f2aecec1adf329735dd16a88d7d494a
change-id: 20260130-mptcp-issue-607-tmp-fix-9152922d475b

Best regards,
-- 
Matthieu Baerts (NGI0) <matttbe@kernel.org>
Re: [PATCH mptcp-next] DO-NOT-MERGE: mark some simult flows tests as flaky
Posted by Matthieu Baerts 1 week ago
Hello,

On 30/01/2026 19:39, Matthieu Baerts (NGI0) wrote:
> This is just to reduce the noise while we are working a solution for
> issue 607:
> 
>   selftests: simult_flows: "unbalanced bwidth with opposed, unbalanced
>   delay" (+ "reverse direction") are unstable
> 
> Suggested by Paolo: commit "mptcp: better mptcp-level RTT estimator" is
> probably correct, but likely it uncovers some underlying issues (in ack
> generation?).
> 
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> ---
> To be placed just after/before the commit causing the instabilities.

FYI, I just applied the patch:

New patches for t/upstream:
- 87173196aabf: DO-NOT-MERGE: mark some simult flows tests as flaky
- Results: 6f5b41319f11..847c469e539c (export)

Tests are now in progress:

- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/a8ef10a37d4254bf9b07108ccd01a4b7b35fc5b5/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.